Fixed issue #1899 #1943
Fixed issue #1899 #1943
Conversation
ghost
self-requested a review
as a 
There was a problem hiding this comment.
There seems to have been a lot of copying and pasting here which has missed several items - including the title and slug, so I assume you didn't check this on localhost. I fixed some of them but the second one is full of mentions of async so if you could check that and update this PR.
If you are going to create new pages I strongly suggest getting set up to test on localhost as that would have highlighted the fact you still had the slug for the for page which I assume you based this off.
|
@rachelandrew First of all sorry for so much silly mistake. This was my first time contribution to mozilla. |
ghost
closed this
|
@Aayushap1 no worries, I'll take a look in a bit |
|
I have just made changes that you have told sir but now it is showing checks not successful. |
|
Sir, Please help me, 1 check is failing I don't know why |
|
@Aayushap1 your folder is the wrong name |
Update async index.html
|
@Aayushap1 The failing test is related to it:
It should go away once the folder has the correct name. |
|
@rachelandrew , now everything is fine I solved all the problems please **review and merge ** my pull request. |
|
@rachelandrew @Ryuno-Ki Thanks for helping me in my first contribution to Mozilla and MDN |
|
@rachelandrew please review my PR. |
|
I have added this link in table in line no 43 : https://html.spec.whatwg.org/multipage/scripting.html#attr-script-async |
|
Closed because of plagiarism: see #1712 (comment) |
) using 12%5 to explain how the remainder operator works to some of my coding students was confusing for them since the result of integer division `12 / 5` is *also* 2. I explained that `12 / 5` is 2 with a remainder of 2, so `12 % 2 === 2`. Many of them mistakenly thought that that `%` was just an integer division. I think using 13 in the example would reduce the confusion since the result of integer division `13 / 2` (2) is different from the remainder (3).
I fixed issue #1899 please merge my pull request