New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement font-variant-emoji #22118 #22794
Conversation
…-positon to the sorthand page. Also updated all the links to be markdown links
Can we include a section on accessibility concerns? https://uxdesign.cc/emojis-in-accessibility-how-to-use-them-properly-66b73986b803 includes some good points. For example, repeated emojis lead to a bad user experience for screen reader users. |
I'm surprised—the link doesn't work on GitHub anyway, because it's not a FQDN. All it does is to make it "look like" a link, which I'm not sure is any better. We should never be reading the rendered text on GitHub. At the same time Markdown links make the source longer with a lot of redundant text. (I'm starting to see the value in using xref macros myself) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, @dletorey! Few things will need updating (plus Estelle's comment).
"See also" should follow sentence casing as in other titles. You seemed to have touched a set of pages where it was incorrect 🙂.
@dletorey, adding a note here for you to check my comment in the BCD PR for this property: mdn/browser-compat-data#18381 (comment) |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
I have added an accessibilty concerns section to the page. |
Fixed this and created a new Pull Request |
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you 👍
Description
Created the
font-variant-emoji
page documented and added an exampleCreated links in
font-variant
shorthand,font-variant-alternates
,font-variant-caps
,font-variant-east-asian
,font-variant-ligatures
,font-variant-numeric
andfont-variant-position
properties.Also added values fo
font-variant-position
tofont-variant
Updated all the cssxref macro in these pages to be markdown links (based on @hamishwillee's advice) to make links work in github as well as mdn.
Motivation
Documenting the firefox release for {
font-variant-emoji
](#22118)Additional details
Related issues and pull requests
Fixes #22118