Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement font-variant-emoji #22118 #22794

Merged
merged 29 commits into from Dec 15, 2022
Merged

Implement font-variant-emoji #22118 #22794

merged 29 commits into from Dec 15, 2022

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Dec 7, 2022

Description

Created the font-variant-emoji page documented and added an example

Created links in font-variant shorthand, font-variant-alternates, font-variant-caps, font-variant-east-asian, font-variant-ligatures, font-variant-numeric and font-variant-position properties.

Also added values fo font-variant-position to font-variant

Updated all the cssxref macro in these pages to be markdown links (based on @hamishwillee's advice) to make links work in github as well as mdn.

Motivation

Documenting the firefox release for {font-variant-emoji](#22118)

Additional details

Related issues and pull requests

Fixes #22118

@dletorey dletorey requested a review from a team as a code owner December 7, 2022 16:18
@dletorey dletorey requested review from dipikabh and removed request for a team December 7, 2022 16:18
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Preview URLs (8 pages)
Flaws (3)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/font-variant-ligatures
Title: font-variant-ligatures
Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/contextual_forms does not exist
  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Web/CSS/font-variant-emoji
Title: font-variant-emoji
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://
External URLs (2)

URL: /en-US/docs/Web/CSS/font-variant-emoji
Title: font-variant-emoji

(comment last updated: 2022-12-15 10:26:59)

@estelle
Copy link
Member

estelle commented Dec 8, 2022

Can we include a section on accessibility concerns? https://uxdesign.cc/emojis-in-accessibility-how-to-use-them-properly-66b73986b803 includes some good points. For example, repeated emojis lead to a bad user experience for screen reader users.

@Josh-Cena
Copy link
Member

Josh-Cena commented Dec 8, 2022

make links work in github as well as mdn.

I'm surprised—the link doesn't work on GitHub anyway, because it's not a FQDN. All it does is to make it "look like" a link, which I'm not sure is any better. We should never be reading the rendered text on GitHub. At the same time Markdown links make the source longer with a lot of redundant text. (I'm starting to see the value in using xref macros myself)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, @dletorey! Few things will need updating (plus Estelle's comment).

"See also" should follow sentence casing as in other titles. You seemed to have touched a set of pages where it was incorrect 🙂.

files/en-us/web/css/font-variant-emoji/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant-emoji/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant-emoji/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant-emoji/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant-emoji/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant-east-asian/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant-caps/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/font-variant-alternates/index.md Outdated Show resolved Hide resolved
@dipikabh
Copy link
Contributor

dipikabh commented Dec 8, 2022

@dletorey, adding a note here for you to check my comment in the BCD PR for this property: mdn/browser-compat-data#18381 (comment)

dletorey and others added 15 commits December 14, 2022 12:04
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
dletorey and others added 6 commits December 14, 2022 12:16
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey
Copy link
Contributor Author

Can we include a section on accessibility concerns? https://uxdesign.cc/emojis-in-accessibility-how-to-use-them-properly-66b73986b803 includes some good points. For example, repeated emojis lead to a bad user experience for screen reader users.

I have added an accessibilty concerns section to the page.

@dletorey
Copy link
Contributor Author

@dletorey, adding a note here for you to check my comment in the BCD PR for this property: mdn/browser-compat-data#18381 (comment)

Fixed this and created a new Pull Request

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

dletorey and others added 3 commits December 15, 2022 10:09
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 👍

@dipikabh dipikabh merged commit c6f9207 into mdn:main Dec 15, 2022
@dletorey dletorey deleted the 22118 branch December 21, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Not release] [CSS] Implement font-variant-emoji
4 participants