Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22118 108 release notes #22797

Merged
merged 6 commits into from Dec 15, 2022
Merged

22118 108 release notes #22797

merged 6 commits into from Dec 15, 2022

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Dec 7, 2022

Description

Added release note for font-variant-emoji

Motivation

Working on documenting https://bugzilla.mozilla.org/show_bug.cgi?id=1461589

Additional details

Related issues and pull requests

#22118

Pull Requests

@dletorey dletorey requested review from a team as code owners December 7, 2022 16:39
@dletorey dletorey requested review from dipikabh and removed request for a team December 7, 2022 16:39
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Other Any docs not covered by another "Content:" label labels Dec 7, 2022
@dletorey dletorey mentioned this pull request Dec 7, 2022
Closed
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022 •
edited

Preview URLs (9 pages)
Flaws (3)

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/font-variant-ligatures
Title: font-variant-ligatures
Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/contextual_forms does not exist
  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Web/CSS/font-variant-emoji
Title: font-variant-emoji
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://
External URLs (1)

URL: /en-US/docs/Web/CSS/font-variant-emoji
Title: font-variant-emoji

(comment last updated: 2022-12-14 16:57:30)

dipikabh
dipikabh requested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dletorey, reviewed only the release note file here since the other files are part of #22794.

files/en-us/mozilla/firefox/releases/108/index.md Outdated Show resolved Hide resolved
@dletorey @dipikabh
Update files/en-us/mozilla/firefox/releases/108/index.md
529be6b 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
dipikabh
dipikabh approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dipikabh
Copy link
Contributor

dipikabh commented Dec 14, 2022 •
edited

So this PR is good and ready to land. I am wondering if you should push another commit here with only the release file and all other files removed. Otherwise we might have to watch for the order of merging this PR and #22794. We wouldn't want any conflicts or overwrites.

Also, there is a markdownlint error here that would need to be resolved. Pinging @bsmth to see if he can help troubleshooting the cause.
UPDATE: @schalkneethling helped clear the markdownlint error. Thank you!

bsmth
bsmth reviewed Dec 15, 2022
View reviewed changes
files/en-us/web/css/font-variant-alternates/index.md
- {{cssxref("font-variant-east-asian")}}
- {{cssxref("font-variant-ligatures")}}
- {{cssxref("font-variant-numeric")}}
- {{cssxref("@font-feature-values")}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cssxref is still being used. Should we revert this change and use the macro for the additions?

bsmth
bsmth reviewed Dec 15, 2022
View reviewed changes
files/en-us/web/css/font-variant-caps/index.md
- [`font-variant-emoji`](/en-US/docs/Web/CSS/font-variant-emoji)
- [`font-variant-ligatures`](/en-US/docs/Web/CSS/font-variant-ligatures)
- [`font-variant-numeric`](/en-US/docs/Web/CSS/font-variant-numeric)
- [`font-variant-position`](/en-US/docs/Web/CSS/font-variant-position)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and in files/en-us/web/css/font-variant-east-asian/index.md below

bsmth
bsmth reviewed Dec 15, 2022
View reviewed changes
files/en-us/mozilla/firefox/releases/108/index.md
@@ -29,6 +29,7 @@ This article provides information about the changes in Firefox 108 that will aff
- Container query length units are now supported via the the `layout.css.container-queries.enabled` preference, which is set to `false` by default.
Setting this preference to `true` allows the use of `cqw`, `cqh`, `cqi`, `cqb`, `cqmin`, and `cqmax` units of length which are relative to the size of a query container.
For more information on these units, see the [CSS Container Queries](/en-US/docs/Web/CSS/CSS_Container_Queries#container_query_length_units) documentation ({{bug(1744231)}}).
- The [`font-variant-emoji`](/en-US/docs/Web/CSS/font-variant-emoji) property is now supported via the `layout.css.font-variant-emoji.enabled` preference, which is set to `false` by default. This property allows you to set a default presentation style for displaying emojis ({{bug(1461589)}}).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not enabled by default, then I think we should be adding this to the experimental features page.

@dletorey dletorey merged commit 6a3d81d into mdn:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth left review comments

@dipikabh dipikabh dipikabh approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dletorey @dipikabh @bsmth