Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update docs to reflect current w3c state of document.hidden flag #26418

Closed
wants to merge 3 commits into from

Conversation

DeepUpRosenthal
Copy link

As stated here w3c/page-visibility#64 the .hidden prop is not deprecated.

As stated here w3c/page-visibility#64 the `.hidden` prop is not deprecated.
@DeepUpRosenthal DeepUpRosenthal requested a review from a team as a code owner April 25, 2023 19:16
@DeepUpRosenthal DeepUpRosenthal requested review from sideshowbarker and removed request for a team April 25, 2023 19:16
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 25, 2023
@DeepUpRosenthal DeepUpRosenthal changed the title doc: update docs to reflect current w3c state doc: update docs to reflect current w3c state of document.hidden flag Apr 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023

Preview URLs

(comment last updated: 2023-05-20 00:22:12)

@estelle
Copy link
Member

estelle commented Apr 25, 2023

While not deprecated, {{domxref("Document.visibilityState")}} is a better option and should be recommended. While the statement should be edited, the recommendation/link shouldn't be removed

@sideshowbarker sideshowbarker removed their request for review April 26, 2023 02:12
@DeepUpRosenthal
Copy link
Author

I would remove this notice entirely as it is confusing for devs if the prop isn't deprecated. Just my opinion as a dev. I'd put a "See also" section at the bottom of the document where the visibilityState prop page is linked. What do you think?

@teoli2003
Copy link
Member

What I would do is to:

  • Move the warning in usage notes, where the original note was.
  • Transform it into a note and rephrase it a bit to sound more like "Why you should use visibilityState instead of hidden". (Make it more browser-independent.)
  • Add a link to visibilityState in the See also section.

What do you think?

@Josh-Cena Josh-Cena added the awaiting response Awaiting for author to address review/feedback label May 21, 2023
@bsmth
Copy link
Member

bsmth commented Jun 15, 2023

hi @DeepUpRosenthal there's some review comments outstanding on this submission, would you like to take a look? Thank you :)

@wbamberg
Copy link
Collaborator

wbamberg commented Nov 2, 2023

Closing in favour of #29974.

@wbamberg wbamberg closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Awaiting for author to address review/feedback Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants