Skip to content
This repository has been archived by the owner on Jul 18, 2022. It is now read-only.

Editorial: remove note about hidden being 'historical' #64

Merged
merged 1 commit into from Sep 15, 2020
Merged

Conversation

marcoscaceres
Copy link
Member

closes #63

@yoavweiss
Copy link
Contributor

What's the best practice to indicate that some features are ones that developers should not be using, even if we don't have a clear path to deprecate and remove them?

@marcoscaceres
Copy link
Member Author

I'd suggest us updating MDN for maximum reach - as most developers will end up there, rather than here... however, we can also mark things up as "best-practice"... but to be honest, specs making "best practice" suggestions is not great. I understand why we might want to encourage developers to use the enums, but still, using hidden doesn't seem to have any disadvantages over using the enum value.

@yoavweiss
Copy link
Contributor

@igrigorik - thoughts?

@igrigorik
Copy link
Member

What's the downside of providing guidance both here and in MDN? At the end of the day, the spec is the source of truth, not MDN. /cc @philipwalton for opinions™.

@marcoscaceres
Copy link
Member Author

I guess I'm also questioning the validity of the advice: there doesn't seem to be any valid technical or performance or other reason to avoid using .hidden (that I can see - but please educate me if there is).

Given that .hidden seems to be non-harmful, and has no side-effects, we should really just leave it to authors to choose which is best for their code.

Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW given that we do not intend to extend the set of possible visibility states in the near future I agree with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treating .hidden as "historical" seems unhelpful
4 participants