Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-XHRify SourceBuffer example #30423

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Nov 21, 2023

This is according to my list the last bit of #30131 🌮 .

It is a bit tricky because the underlying example lives somewhere else and I can't update it. I will ask the author if he's willing to transfer it to dom-examples, but I don't think it should block this PR, as the code in the page has already diverged from the example (and it seems that the example does not work any more because we need user activation for the video to play).

I have tested this version though and it seems to work.

@wbamberg wbamberg requested a review from a team as a code owner November 21, 2023 05:18
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team November 21, 2023 05:18
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Preview URLs

Flaws (6)

URL: /en-US/docs/Web/API/SourceBuffer
Title: SourceBuffer
Flaw count: 6

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/SourceBuffer/abort_event does not exist
    • /en-US/docs/Web/API/SourceBuffer/error_event does not exist
    • /en-US/docs/Web/API/SourceBuffer/update_event does not exist
    • /en-US/docs/Web/API/SourceBuffer/updateend_event does not exist
    • and 1 more flaws omitted
External URLs (1)

URL: /en-US/docs/Web/API/SourceBuffer
Title: SourceBuffer

(comment last updated: 2023-11-21 05:25:34)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants