New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init documentation for `cancelAnimationFrame()` and `requestAnimationFrame()` of `DedicatedWorkerGlobalScope` interface #30880

Merged

teoli2003 merged 31 commits into mdn:main from skyclouds2001:animation-frame

Dec 14, 2023

Contributor

skyclouds2001 commented Dec 8, 2023

Description

see https://developer.mozilla.org/en-US/docs/Web/API/Window/requestAnimationFrame and https://developer.mozilla.org/en-US/docs/Web/API/Window/cancelAnimationFrame

reference to https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#animation-frames

using some content from Window.requestAnimationFrame() and Window.cancelAnimationFrame() and the example from the specification

Motivation

Additional details

Relates to #1519

Related issues and pull requests

skyclouds2001 added 5 commits

December 6, 2023 22:42


          init

cd5adf5


          update example

3b71eca


          update list

0d992d7


          style pretty

f13e476


          update additional info

4456be9

github-actions bot added the Content:WebAPI label

github-actions bot reviewed

View reviewed changes

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

a71e7de

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Contributor

github-actions bot commented Dec 8, 2023 •

edited

Loading

Preview URLs

(comment last updated: 2023-12-14 14:03:29)

skyclouds2001 added 2 commits

December 9, 2023 03:48


          remove extra comment

aa534ae


          update see also section

26d5453

skyclouds2001 commented

View reviewed changes

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

47758d1

skyclouds2001 marked this pull request as ready for review

December 8, 2023 19:53

skyclouds2001 requested a review from a team as a code owner

December 8, 2023 19:53

skyclouds2001 requested review from Elchi3 and removed request for a team

December 8, 2023 19:53

skyclouds2001 and others added 3 commits

December 9, 2023 16:00


          Merge branch 'main' into animation-frame

9a1e8b2


          update

3e9870a


          Merge branch 'animation-frame' of https://github.com/skyclouds2001/co…

ce7f47c

…ntent into animation-frame

teoli2003 suggested changes

View reviewed changes

Contributor

teoli2003 left a comment

I have a few questions here, and I'll need to do a second pass once all is fixed, but this is close to be mergeable.

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Show resolved Hide resolved

files/en-us/web/api/window/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/window/requestanimationframe/index.md Outdated Show resolved Hide resolved

skyclouds2001 and others added 6 commits

December 11, 2023 02:17


          Apply suggestions from code review

6c7bff1

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>


          update

f656ae7


          update worker

2d94ac0


          better reflect confuse

348782e


          update

ac2d10d


          update content

4cffa3f

skyclouds2001 requested a review from teoli2003

December 11, 2023 12:31

skyclouds2001 commented

View reviewed changes

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

374deb6

skyclouds2001 mentioned this pull request

Update Worker available methods and apis list #30975

Merged

skyclouds2001 commented

View reviewed changes

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

44b28a0

teoli2003 suggested changes

View reviewed changes

Contributor

teoli2003 left a comment

A few last grammar and typo fixes, and this is ready to be merged. Well done!

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

fdf014e

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

github-actions bot reviewed

View reviewed changes

files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

skyclouds2001 commented

View reviewed changes

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md Outdated Show resolved Hide resolved

skyclouds2001 and others added 9 commits

December 14, 2023 21:26


          Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimation…

7e6335a

…frame/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimatio…

4ebea4c

…nframe/index.md

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>


          Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimatio…

69adf78

…nframe/index.md

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>


          Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimatio…

d98bbda

…nframe/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimatio…

5f2acd3

…nframe/index.md


          Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimatio…

ec3e9f1

…nframe/index.md


          Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimation…

83b6f16

…frame/index.md


          Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimation…

839b919

…frame/index.md


          Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimation…

9bcbb48

…frame/index.md

teoli2003 approved these changes

View reviewed changes

Contributor

teoli2003 left a comment

Thank you!


          Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimatio…

24abbf4

…nframe/index.md

teoli2003 merged commit 843f6ef into mdn:main

7 checks passed

skyclouds2001 deleted the animation-frame branch

December 14, 2023 14:28

skyclouds2001 mentioned this pull request

Add mdn_url for DedicatedWorkerGlobalScope.cancelAnimationFrame() & DedicatedWorkerGlobalScope.requestAnimationFrame() mdn/browser-compat-data#21629

Merged

dipikabh pushed a commit to dipikabh/content that referenced this pull request


          init documentation for cancelAnimationFrame() and `requestAnimation…

70b6c67

…Frame()` of `DedicatedWorkerGlobalScope` interface (mdn#30880)

* init

* update example

* update list

* style pretty

* update additional info

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* remove extra comment

* update see also section

* Apply suggestions from code review

* update

* Apply suggestions from code review

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

* update

* update worker

* better reflect confuse

* update

* update content

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

* Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>

* Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md

Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>

* Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md

* Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md

* Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md

* Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md

* Update files/en-us/web/api/dedicatedworkerglobalscope/cancelanimationframe/index.md

* Update files/en-us/web/api/dedicatedworkerglobalscope/requestanimationframe/index.md

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

skyclouds2001 mentioned this pull request

DedicatedWorkerGlobalScope.requestAnimationFrame - Not supported in nested Web Workers on Chromium mdn/browser-compat-data#21964

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels