Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more reviewers for SVG content #32996

Merged
merged 1 commit into from Apr 9, 2024
Merged

Add more reviewers for SVG content #32996

merged 1 commit into from Apr 9, 2024

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Apr 8, 2024 •
edited

Description

We want to expand the pool of reviewers who can review the PRs being opened in the SVG content area. With the removal of SVG-specific section from CODEOWNERS, PRs can fallback to the default yari-content-mdn team:

# ----------------------------------------------------------------------------
# DEFAULT ENGLISH CONTENT OWNER(S)
# ----------------------------------------------------------------------------
/files/en-us/    @mdn/yari-content-mdn

To Do:

@dipikabh dipikabh requested a review from a team as a code owner April 8, 2024 11:34
@github-actions github-actions bot added system Infrastructure and configuration for the project size/s 6-50 LoC changed labels Apr 8, 2024
@dipikabh dipikabh requested review from a team and pepelsbey and removed request for a team April 8, 2024 11:41
bsmth
bsmth approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@dipikabh dipikabh requested review from Rumyra and Ryuno-Ki April 8, 2024 17:04
pepelsbey
pepelsbey approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@bsmth
Copy link
Member

bsmth commented Apr 9, 2024

The team's already removed, so we should merge so the codeowners file is valid (see https://github.com/mdn/content/pull/32828/files)

@bsmth bsmth merged commit 6693306 into mdn:main Apr 9, 2024
6 of 7 checks passed
@dipikabh dipikabh deleted the update-codeowners branch April 9, 2024 11:49
Ryuno-Ki added a commit that referenced this pull request Apr 15, 2024
@Ryuno-Ki
Update REVIEWING.md
07cfdf0 
As I received an email about the [SVG review team being dissolved](#32996) (which I'm absolutely fine with!), I propose to update the REVIEWING.md as well.

I hereby ask to be moved to the Alumni section.
@Ryuno-Ki Ryuno-Ki mentioned this pull request Apr 15, 2024
Merged
dipikabh pushed a commit that referenced this pull request Apr 16, 2024
@Ryuno-Ki
Update REVIEWING.md (#33102)
034ea75 
As I received an email about the [SVG review team being dissolved](#32996) (which I'm absolutely fine with!), I propose to update the REVIEWING.md as well.

I hereby ask to be moved to the Alumni section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

@bsmth bsmth bsmth approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

@Ryuno-Ki Ryuno-Ki Awaiting requested review from Ryuno-Ki

Assignees
No one assigned
Labels
size/s 6-50 LoC changed system Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dipikabh @bsmth @pepelsbey