<details> toggle event improvements #33750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Preview URLs (comment last updated: 2024-05-25 12:28:14) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Note that the link to why attribute event listeners are discouraged does not work in the preview URLs provided by a bot above. I have tested it locally there it works. It should link to this page: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes#event_handler_attributes |
sideshowbarker
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed event type info (was
Eventbut is actuallyToggleEvent).Added a bad example with an explainer note.
Motivation
I recently had to work on a legacy application and the only way I could use the toggle event was with an attribute event handler. This is when I came across the surprising behavior when the
openattribute is set initially. I thought it was worth mentioning here but I can remove that part if it is considered not helpful.