Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<details> toggle event improvements #33750

Merged
merged 2 commits into from
May 25, 2024
Merged

<details> toggle event improvements #33750

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6f8f53
<details> toggle event improvements
tim-we May 25, 2024
28f16e1
Update files/en-us/web/api/htmldetailselement/toggle_event/index.md
tim-we May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions files/en-us/web/api/htmldetailselement/toggle_event/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,25 @@ This event is not cancelable and does not bubble.

Use the event name in methods like {{domxref("EventTarget.addEventListener", "addEventListener()")}}, or set an event handler property.

```js
```js example-good
addEventListener("toggle", (event) => {});

ontoggle = (event) => {};
```

```html example-bad
<details ontoggle="console.log(this.open)" open>
...
</details>
tim-we marked this conversation as resolved.
Show resolved Hide resolved
```

> **Note:** In the example above the event listener will be called once without any user interaction because the `open` attribute is set. Using event handlers like this [is discouraged](/en-US/docs/Web/HTML/Attributes#event_handler_attributes).

## Event type

A generic {{domxref("Event")}}.
A {{domxref("ToggleEvent")}}. Inherits from {{domxref("Event")}}.

{{InheritanceDiagram("ToggleEvent")}}

## Examples

Expand Down
Loading