Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing is simple #360

Merged
merged 6 commits into from Dec 20, 2020
Merged

Nothing is simple #360

merged 6 commits into from Dec 20, 2020

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 17, 2020

Okay, let me test regex-driven-documentation, too! 😄

I don't know... is this reviewable?

(seriously, feel free to decline this, I've not looked into all files if it does any harm)

Credits to Mike Taylor https://twitter.com/miketaylr/status/1339601766518673414

@Elchi3 Elchi3 requested review from a team as code owners December 17, 2020 16:40
@Elchi3 Elchi3 requested review from a team December 17, 2020 16:40
@Elchi3 Elchi3 requested review from a team as code owners December 17, 2020 16:40
@Elchi3 Elchi3 requested a review from a team December 17, 2020 16:40
@Elchi3 Elchi3 requested a review from a team as a code owner December 17, 2020 16:40
@chrisdavidmills
Copy link
Contributor

LOL, I love this.

I think I'd be inclined to merge this, as long as you check for the outliers @miketaylr highlights.

I just checked about 50 or 60 of them, and it is no worse and usually better in each case.

@sideshowbarker
Copy link
Collaborator

If we were to want to dial this back more, could refine the pattern to limit the match to instances of /you simply/, /, simply/ and maybe whatever else of that kind we could glean out. But I agree with @chrisdavidmills about the results of this as-is being “no worse and usually better in each case” — modulo the “Simply put” stuff that @miketaylr pointed out, and the other “Simply [verb]” stuff. So if we wanted to really ban “[sS]imply” in all cases, could first do a replacement of those “Simply” cases, and then for going forward we could actually put a “[sS]imply” lint/flaw check in place.

@vkWeb
Copy link
Member

vkWeb commented Dec 17, 2020

This is simply amazing. 🤣 🤣

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 18, 2020

Added a follow-up commit that deals with uppercase "Simply".
Often, the next word needed to be in uppercase and sometimes I replaced idioms like "Simply put, " with "In other words, ".

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked to the changes to the "add-ons" related pages, and so I'm approving those on behalf of the Add-ons Team.

@Elchi3 Elchi3 requested review from a team and fiji-flo December 19, 2020 15:59
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a good look, and I reckon we are ready to merge this!

@chrisdavidmills chrisdavidmills merged commit 423ae58 into mdn:main Dec 20, 2020
@Elchi3 Elchi3 deleted the nothing-is-simple branch December 20, 2020 14:47
@Elchi3
Copy link
Member Author

Elchi3 commented Dec 20, 2020

Thanks Chris! \o/

@miketaylr
Copy link

This is awesome, thanks @Elchi3 et al.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants