Fix content and display bug on videoWidth page #4059

amyrlam · 2021-04-13T08:37:30Z

What was wrong/why is this fix needed? (quick summary only)

Page had broken anchor tag, switch to more informative external link
Page had duplicate macro that incorrectly showed up as macro text itself

MDN URL of main page changed

https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Issue number (if there is an associated issue)

Resolves: #1657

Anything else that could help us review it

I'm not sure how to run things locally (is that expected? didn't see it in the README or elsewhere) so am trying this since the Preview URL on #4058 doesn't seem to reflect changes made in later commits(?). Not sure what I'm missing yet.

github-actions · 2021-04-13T08:39:42Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

amyrlam · 2021-04-13T08:42:31Z

files/en-us/web/api/htmlvideoelement/videowidth/index.html

@@ -21,8 +21,7 @@
 <p><span class="seoSummary">The {{domxref("HTMLVideoElement")}} interface's read-only
    <code><strong>videoWidth</strong></code> property indicates the <strong>intrinsic
      width</strong> of the video, expressed in CSS pixels. In simple terms, this is the
-    width of the media in its natural size.</span> See {{anch("About intrinsic width and
-  height")}} for more details.</p>
+    width of the media in its natural size.</span> See {{Glossary("Intrinsic size")}} for more details.</p>


This is broken on the Preview URL https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth, but exists https://developer.mozilla.org/en-US/docs/Glossary/Intrinsic_Size, what am I missing?

I changed the casing before from "Intrinsic size" to "Intrinsic Size" but didn't see an update on the Preview URL on the prior PR. Where to learn more about the macros?

Sorry about the Preview URLs. This preview just landed the other week and there were problems with caching. Likely why you didn't see updates.

So, this means to link to the section that the {{page}} macro below should render but doesn't. I see you fixed that {{page}} macro call, so I reckon we can have the anchor back. What do you think?

@Elchi3 Thank you for your help!

Sounds good, made that change. I'm stumped why the link has an extra _ though?

How strange?! Is it because there is a line break in line 24 and 25 in the middle of the {{anch}} macro call? Can you try making that one line and see if that fixes it?

@Elchi3 Tried that and undid the commit. FWIW it's wrong on production https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement/videoWidth#about_intrinsic_width_and__height, seems like a legit bug with anch.

I can change the heading to "About" (one word) or something, but wasn't sure how you want to proceed?

Also, I can file an issue / look into it if you can advise where it is? Took a quick look at mdn on GitHub but didn't know.

Oh, that's so weird! We don't really like our macros and so we could also avoid the macro call altogether and use good old HTML (we plan to convert the HTML to markdown and so the less macros the better).

The anch code lives here: https://github.com/mdn/yari/blob/main/kumascript/macros/anch.ejs

@Elchi3 aha, yes migrating to HTML sounds great. Thanks for sharing the macro anyways!

The fix looks good on the latest preview URL #4059 (comment), and I squashed my commits, take a look at your convenience.

github-actions · 2021-04-13T08:44:48Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

files/en-us/web/api/htmlvideoelement/videowidth/index.html

github-actions · 2021-04-13T08:50:50Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

amyrlam · 2021-04-13T08:58:39Z

One last note, thanks for bearing with me: I can fix the broken link to resize from #4059 (comment) also (can see on https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement/videoHeight, resize is in red, does not exist) but not sure if there should be a link, or if the link should simply be removed?

Ryuno-Ki · 2021-04-16T15:52:45Z

Ping @Elchi3.
I'm not that comfortable with the Macros edited in this PR.

Elchi3 · 2021-04-16T18:27:43Z

One last note, thanks for bearing with me: I can fix the broken link to resize from #4059 (comment) also (can see on https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement/videoHeight, resize is in red, does not exist) but not sure if there should be a link, or if the link should simply be removed?

hm interesting. Not sure if HTMLVideoElement has a dedicated resize event, so I'm also unclear what this is trying to refer to. Feel free to ignore that for this PR, though. Might be good to raise an issue about it, however.

github-actions · 2021-04-19T03:38:22Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

amyrlam · 2021-04-19T03:45:49Z

@Elchi3 I made a separate issue for the broken resize link here: #4230.

github-actions · 2021-04-19T16:12:47Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

github-actions · 2021-04-19T16:25:33Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 3

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist
- `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:23
  21| }
  22| %>

23| <%- await wiki.page(url, $1, $2, $3, $4) %>
24|

unable to find an HTML element with an "id" of "About_intrinsic_width_and__height" within /en-us/docs/web/api/htmlvideoelement/videoheight`

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

github-actions · 2021-04-19T16:29:03Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

github-actions · 2021-04-19T18:40:41Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

Resolves: mdn#1657 Use HTML instead of anch macro

github-actions · 2021-04-19T18:48:01Z

Preview URLs

https://pr4059.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLVideoElement/videoWidth

Flaws

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLMediaElement/resize does not exist
- /en-US/docs/Web/API/HTMLVideoElement/resize does not exist

External URLs

URL: /en-US/docs/Web/API/HTMLVideoElement/videoWidth
Title: HTMLVideoElement.videoWidth
on GitHub

https://html.spec.whatwg.org/multipage/ (1 time)
https://www.w3.org/TR/html52/semantics-embedded-content.html (1 time)

Elchi3

Thanks for your patience with this one, @amyrlam! Congrats on landing your first PR to MDN! 🎉

amyrlam · 2021-04-20T16:55:16Z

Thank you @Elchi3 for all of your help!

amyrlam requested a review from a team as a code owner April 13, 2021 08:37

amyrlam requested review from Elchi3 and removed request for a team April 13, 2021 08:37

amyrlam commented Apr 13, 2021

View reviewed changes

files/en-us/web/api/htmlvideoelement/videowidth/index.html Show resolved Hide resolved

amyrlam mentioned this pull request Apr 13, 2021

Fix content/display bug on videoWidth page #4058

Closed

amyrlam force-pushed the bug/video-width-page-2 branch from d713ffc to bc6d95f Compare April 13, 2021 08:49

amyrlam mentioned this pull request Apr 13, 2021

Issue with "HTMLVideoElement.videoWidth": … #1657

Closed

amyrlam mentioned this pull request Apr 19, 2021

Content bug: Link to resize on HTMLVideoElement is broken #4230

Closed

amyrlam force-pushed the bug/video-width-page-2 branch from 2270d01 to 02da037 Compare April 19, 2021 16:26

Fix content and display bug on videoWidth page

89ed713

Resolves: mdn#1657 Use HTML instead of anch macro

amyrlam force-pushed the bug/video-width-page-2 branch from f433e2a to 89ed713 Compare April 19, 2021 18:46

Elchi3 approved these changes Apr 20, 2021

View reviewed changes

Elchi3 merged commit f432ae5 into mdn:main Apr 20, 2021

amyrlam deleted the bug/video-width-page-2 branch April 20, 2021 16:55

github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix content and display bug on videoWidth page #4059

Fix content and display bug on videoWidth page #4059

amyrlam commented Apr 13, 2021

github-actions bot commented Apr 13, 2021

amyrlam Apr 13, 2021

Elchi3 Apr 16, 2021

Elchi3 Apr 16, 2021

amyrlam Apr 19, 2021

Elchi3 Apr 19, 2021 •

edited

Loading

amyrlam Apr 19, 2021

Elchi3 Apr 19, 2021

amyrlam Apr 19, 2021

github-actions bot commented Apr 13, 2021

github-actions bot commented Apr 13, 2021

amyrlam commented Apr 13, 2021

Ryuno-Ki commented Apr 16, 2021

Elchi3 commented Apr 16, 2021

github-actions bot commented Apr 19, 2021

amyrlam commented Apr 19, 2021

github-actions bot commented Apr 19, 2021

github-actions bot commented Apr 19, 2021

github-actions bot commented Apr 19, 2021

github-actions bot commented Apr 19, 2021

github-actions bot commented Apr 19, 2021

Elchi3 left a comment

amyrlam commented Apr 20, 2021

Fix content and display bug on videoWidth page #4059

Fix content and display bug on videoWidth page #4059

Conversation

amyrlam commented Apr 13, 2021

github-actions bot commented Apr 13, 2021

Preview URLs

Flaws

External URLs

amyrlam Apr 13, 2021

Choose a reason for hiding this comment

Elchi3 Apr 16, 2021

Choose a reason for hiding this comment

Elchi3 Apr 16, 2021

Choose a reason for hiding this comment

amyrlam Apr 19, 2021

Choose a reason for hiding this comment

Elchi3 Apr 19, 2021 • edited Loading

Choose a reason for hiding this comment

amyrlam Apr 19, 2021

Choose a reason for hiding this comment

Elchi3 Apr 19, 2021

Choose a reason for hiding this comment

amyrlam Apr 19, 2021

Choose a reason for hiding this comment

github-actions bot commented Apr 13, 2021

Preview URLs

Flaws

External URLs

github-actions bot commented Apr 13, 2021

Preview URLs

Flaws

External URLs

amyrlam commented Apr 13, 2021

Ryuno-Ki commented Apr 16, 2021

Elchi3 commented Apr 16, 2021

github-actions bot commented Apr 19, 2021

Preview URLs

Flaws

External URLs

amyrlam commented Apr 19, 2021

github-actions bot commented Apr 19, 2021

Preview URLs

Flaws

External URLs

github-actions bot commented Apr 19, 2021

Preview URLs

Flaws

External URLs

github-actions bot commented Apr 19, 2021

Preview URLs

Flaws

External URLs

github-actions bot commented Apr 19, 2021

Preview URLs

Flaws

External URLs

github-actions bot commented Apr 19, 2021

Preview URLs

Flaws

External URLs

Elchi3 left a comment

Choose a reason for hiding this comment

amyrlam commented Apr 20, 2021

Elchi3 Apr 19, 2021 •

edited

Loading