Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title vrdisp #4860

Merged
merged 2 commits into from
May 12, 2021
Merged

Fix title vrdisp #4860

merged 2 commits into from
May 12, 2021

Conversation

hamishwillee
Copy link
Collaborator

VRDisplay.hardwareUnitId and VRDisplay.resetPose both misnamed with incorrect prefix VRDevice.

This also fixes VRDisplay to mark all properties as deprecated (as per BCD and lower-level docs) and to merge the separate sections "deprecated methods" and "obsolete methods" back into the main methods/properties - since if all are deprecated these are not helpful categories.

@hamishwillee hamishwillee requested a review from a team as a code owner May 10, 2021 06:44
@hamishwillee hamishwillee requested review from jpmedley and removed request for a team May 10, 2021 06:44
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/VRDisplay
Title: VRDisplay
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/API/VRDisplay
Title: VRDisplay
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/VRDisplay/hardwareUnitId
Title: VRDisplay.hardwareUnitId
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/VRDisplay/resetPose
Title: VRDisplay.resetPose()
on GitHub

No new external URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamishwillee !

@wbamberg wbamberg merged commit 4bb8aaa into mdn:main May 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants