Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA Roles #9305

Merged
merged 140 commits into from
Oct 18, 2021
Merged

ARIA Roles #9305

merged 140 commits into from
Oct 18, 2021

Conversation

estelle
Copy link
Member

@estelle estelle commented Sep 27, 2021 •
edited
Loading

Addresses issue: #4776

  • Create a new landing page for ARIA roles.
  • Complete most of the document structure, landmark, live region, window, and abstract roles (basically, still working on widget roles.

Additional issues addressed:

Note the pages with "needscontent" tag and {{draft}} only had an auto md conversion. Each of those will be edited and in individual PRs

@estelle
converted all existing html to MD.
5cdcab4
@estelle
wrote the alertdialog page. Also tweaked the alert and dialog role pages
789771e
@estelle
linked some text and made code look like <code>
f1fff85
@estelle
Work on alertdialog and application roles.
5fb0573
@estelle
timer role url is different and is missing a lot of content, includin…
a2d3e25 
…g xxx
@estelle
the url was different from all the others
0ddfddc
@estelle
moved timer role
1238839
@estelle
removed draft status
3a0e06b
@estelle
md'ed it
206b2aa
@estelle
updated see also
dcbcae9
@estelle
md'ed it. looks complete. yay
a118462
@estelle
mdified and made into more of a 'don't use this'
bf83b8a
@estelle
mdification
f7da3dc
@estelle
MD'ed the file, and made it more opinionated
aac7444
@estelle
start of file
857a0a0
@estelle
added presentation role
412bcca
@estelle
treegrid was written as gridtree
9da921c
@estelle
rewrote the whole page
a4637ad
@estelle
updated links and time example
d36465d
@estelle
update description of roles on role home page.
417049d
@estelle
finessed teh landing page
ab3947f
@estelle
updated checkbox role
ada816b
@estelle
columnheader page
a600470
@estelle
merged with upstream main
ee3ac1e
@estelle
Roletype brief description
305f824
@estelle
created and wrote widget role
9d6be32
@estelle
minor edits
d0a96f6
@estelle
tweaks, esp in see also
4a376cb
@estelle
restart on combobox
d46b23f
@estelle
merge
b6fa12d
ericwbailey
ericwbailey suggested changes Oct 4, 2021
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle Here's some feedback. I'm going to conduct this PR in small bits because its size is causing my browser to freeze/crash.

files/en-us/web/accessibility/aria/roles/alert_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alert_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alertdialog_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alertdialog_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alertdialog_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alertdialog_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alertdialog_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alertdialog_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/alertdialog_role/index.md Outdated Show resolved Hide resolved
estelle and others added 3 commits October 4, 2021 13:52
ericwbailey
ericwbailey suggested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle Round 2!

files/en-us/web/accessibility/aria/roles/alert_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/application_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/application_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/application_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/application_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/application_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/article_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/article_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/article_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/article_role/index.md Outdated Show resolved Hide resolved
@ericwbailey
Copy link
Member

@estelle A few more comments for your consideration!

@estelle @ericwbailey
Apply suggestions from code review
e78f025 
Because @ericwbailey knows what he is talking about! Thanks for the edits!

Co-authored-by: Eric Bailey <ericwbailey@users.noreply.github.com>
@estelle estelle enabled auto-merge (squash) October 18, 2021 18:12
@estelle estelle disabled auto-merge October 18, 2021 18:12
@estelle estelle enabled auto-merge (squash) October 18, 2021 18:13
@estelle estelle disabled auto-merge October 18, 2021 18:30
@estelle estelle requested review from a team as code owners October 18, 2021 18:32
@estelle estelle requested review from teoli2003 and rebloor and removed request for a team October 18, 2021 18:32
ericwbailey
ericwbailey approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving via an offsite discussion with @estelle, where per-role issues will be handled as subsequent per-file PRs.

files/en-us/web/accessibility/aria/roles/banner_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/banner_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/banner_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/banner_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/banner_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/button_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/button_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/button_role/index.md Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/button_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/button_role/index.md Show resolved Hide resolved
@estelle @ericwbailey
Apply suggestions from code review
83d032b 
thanks @ericwbailey

Co-authored-by: Eric Bailey <ericwbailey@users.noreply.github.com>
@estelle estelle dismissed rachelandrew’s stale review October 18, 2021 20:18

Dismissing because i can't figure out how to "resolve". Using is ok.

@estelle estelle merged commit 48174a1 into mdn:main Oct 18, 2021
@estelle estelle deleted the ariaroles branch October 18, 2021 20:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg left review comments

@ericwbailey ericwbailey ericwbailey approved these changes

@rachelandrew rachelandrew Awaiting requested review from rachelandrew

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 was automatically assigned from mdn/yari-content-http

@rebloor rebloor Awaiting requested review from rebloor rebloor was automatically assigned from mdn/yari-content-mozilla-add-ons

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
4 participants
@estelle @ericwbailey @wbamberg @rachelandrew