Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ray-size doesn't have a definition #676

Closed
romainmenke opened this issue Jul 9, 2023 · 0 comments · Fixed by #700
Closed

ray-size doesn't have a definition #676

romainmenke opened this issue Jul 9, 2023 · 0 comments · Fixed by #700
Assignees
@dipikabh
Labels
idle Issues and pull requests with no activity for three months. needs data update

Comments

@romainmenke
Copy link
Contributor

What information was incorrect, unhelpful, or incomplete?

ray-size isn't defined.

What did you expect to see?

I expected it to be defined as closest-side | closest-corner | farthest-side | farthest-corner | sides

Do you have any supporting links, references, or citations?

https://drafts.fxtf.org/motion/#typedef-ray-size

Do you have anything more you want to share?

No response
@romainmenke romainmenke added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 9, 2023
@romainmenke romainmenke mentioned this issue Jul 9, 2023
Closed
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Aug 9, 2023
@caugner caugner added needs data update and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 29, 2023
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Oct 6, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Nov 17, 2023
@dipikabh dipikabh mentioned this issue Jan 5, 2024
Merged
teoli2003 pushed a commit that referenced this issue Jan 6, 2024
@dipikabh
CSS: Update ray() syntax and add values (#700)
34ce070 
### Description

- Fixes #676 
To address listing the values for `<ray-size>`, I've referred to the
instructions in the `mdn/data/docs` section [Store the information in
the
JSONs](https://github.com/mdn/data/blob/main/docs/updating_css_json.md#store-the-information-in-the-jsons),
where it mentions how to handle when "syntax contains references to
specific values".
   
I've added `"syntaxes"` for `ray()` in `syntaxes.json`. I've included
only the keys that have further values. I'm not sure if that's the
correct way to do it though. I am assuming this should be okay because
the complete syntax exists in `functions.json`.

**UPDATE**: `"syntaxes"` is not supported, was getting lint errors. I've
reverted to use `syntax` but expanded the `<ray-size>` and `<position>`
values inline.

- I'm also using this PR to update `ray()` function syntax (mdn/content
PR to add [Formal
syntax](https://pr31514.content.dev.mdn.mozit.cloud/en-US/docs/Web/CSS/ray#formal_syntax)).
With Firefox122 coming out on Jan 23, 2024, `ray()` will be supported by
default, making it standard across browsers. So I've also updated the
status to `standard` (BCD PR with [ray() status
update](https://github.com/mdn/browser-compat-data/pull/21844/files#diff-5153a0172f96a72ece248c9d29cea659e3ecd45c45d81d57b0b6f2f00c57e7b3R98)).
### Motivation

Addressing an issue as well as updating the syntax

### Related issues and pull requests

mdn/browser-compat-data#21844
mdn/content#31514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dipikabh dipikabh

Labels
idle Issues and pull requests with no activity for three months. needs data update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSS: Update ray() syntax and add values dipikabh/data
3 participants
@caugner @romainmenke @dipikabh