Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :blank CSS selector data #298

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Add :blank CSS selector data #298

merged 1 commit into from
Oct 1, 2018

Conversation

myfonj
Copy link
Contributor

@myfonj myfonj commented Sep 17, 2018

For upcoming MDN page, #mdn/browser-compat-data/pull/2841

ExE-Boss
ExE-Boss suggested changes Sep 18, 2018
View reviewed changes
css/selectors.json Outdated Show resolved Hide resolved
@wbamberg
Copy link
Contributor

Thanks for your contribution @myfonj ! We're in the middle of trying to relicense this repo to CC0, so if you want your PR to be merged, please visit #240 and leave a comment that you agree to the licensing change.

ExE-Boss
ExE-Boss approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

review?(@chrisdavidmills, @Elchi3, @wbamberg)

@chrisdavidmills
Copy link
Contributor

Looks good, r+. Thanks for the contribution @myfonj !

@chrisdavidmills chrisdavidmills merged commit 7ab54a0 into mdn:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExE-Boss ExE-Boss ExE-Boss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myfonj @wbamberg @chrisdavidmills @ExE-Boss