Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

MDN infra terraform refactor #4

Merged
merged 9 commits into from
Jun 20, 2018
Merged

MDN infra terraform refactor #4

merged 9 commits into from
Jun 20, 2018

Conversation

limed
Copy link
Contributor

@limed limed commented Jun 8, 2018

This is a code refactor for terraform, PR does a couple of things

  • Every folder within this the infra/apps/mdn/mdn-aws/infra folder is now a module
  • Added a multi-region module that has us-west-2 and us-east-1 and we can enable it using a flag
  • Some of the generic VPC information is now discovered with an info module written by the nubis team (see: https://github.com/nubisproject/nubis-terraform/tree/develop/info). This is based on some information that we publish through our account deployment process
  • Added enable flag so we can turn on and off specific components
  • Added environment variable, doing this allows us to drive the creation of this infrastructure using a CI system

I know this PR is sort of big but please review and ask me any questions if you have any.

@limed
Copy link
Contributor Author

limed commented Jun 8, 2018

Here is a full picture on how I call terraform https://github.com/limed/mozilla-mdn

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @limed! I was able to spin up an initial POC MDN instance using the infrastructure it created.

@escattone
Copy link
Contributor

I re-based this branch by @limed on mdn/master to get rid of the merge conflict. The merge conflict was simple to resolve. It was due to the fact that I had added an additional CloudFront behavior (users/*) during the all-hands to fix a login issue.

@escattone escattone merged commit 4de226e into mdn:master Jun 20, 2018
@limed limed deleted the mdn-refactor branch August 10, 2018 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants