New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grid-area label indicators to div content #1248

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@mamamusings
Copy link
Contributor

mamamusings commented Nov 30, 2018

Clarifies the relationship between the divs in the rendered HTML and the the grid-area names in the grid-template-areas strings. For someone unfamiliar with the concepts already, the relationship between "One" "Two" and "Three" in the rendered HTML and "a" "b" and "c" in the demo code can be confusing.

Added grid-area label indicators to div content
Clarifies the relationship between the divs in the rendered HTML and the the grid-area names in the grid-template-areas strings. For someone unfamiliar with the concepts already, the relationship between "One" "Two" and "Three" in the rendered HTML and "a" "b" and "c"  in the demo code can be confusing.
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 30, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.
@wbamberg
Copy link
Member

wbamberg left a comment

I think this is a nice addition to the example, thanks @mamamusings !

@wbamberg wbamberg merged commit d8bdd29 into mdn:master Nov 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No new issues
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 30, 2018

Congrats on merging your first pull request! 🎉🎉🎉

wbamberg added a commit to kevinsimper/interactive-examples that referenced this pull request Dec 1, 2018

Merge remote-tracking branch 'upstream/master' into patch-1
* upstream/master:
  Put prefixed sticky value before standard value (mdn#1249)
  Added grid-area label indicators to div content (mdn#1248)
  Update dependency mdn-bob to v1.1.20 (mdn#1241)
  Update dependency prettier to v1.15.2 (mdn#1234)
  Update dependency eslint to v5.9.0 (mdn#1233)
  Update dependency stylelint to v9.8.0 (mdn#1232)
  Update dependency npm-run-all to v4.1.5 (mdn#1239)
  Provide valid and more semantic HTML with <audio> (mdn#1236)
  remove Jenkinsfile code related to MozMEAO
  fix issues with the Jenkins build step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment