Added grid-area label indicators to div content #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the relationship between the divs in the rendered HTML and the the grid-area names in the grid-template-areas strings. For someone unfamiliar with the concepts already, the relationship between "One" "Two" and "Three" in the rendered HTML and "a" "b" and "c" in the demo code can be confusing.
|
💖 Thanks for opening this pull request! 💖
|
wbamberg
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
I think this is a nice addition to the example, thanks @mamamusings !
|
Congrats on merging your first pull request! 🎉🎉🎉 |
wbamberg
pushed a commit
to kevinsimper/interactive-examples
that referenced
this pull request
Dec 1, 2018
* upstream/master: Put prefixed sticky value before standard value (mdn#1249) Added grid-area label indicators to div content (mdn#1248) Update dependency mdn-bob to v1.1.20 (mdn#1241) Update dependency prettier to v1.15.2 (mdn#1234) Update dependency eslint to v5.9.0 (mdn#1233) Update dependency stylelint to v9.8.0 (mdn#1232) Update dependency npm-run-all to v4.1.5 (mdn#1239) Provide valid and more semantic HTML with <audio> (mdn#1236) remove Jenkinsfile code related to MozMEAO fix issues with the Jenkins build step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the relationship between the divs in the rendered HTML and the the grid-area names in the grid-template-areas strings. For someone unfamiliar with the concepts already, the relationship between "One" "Two" and "Three" in the rendered HTML and "a" "b" and "c" in the demo code can be confusing.