Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: name attribute value fix for first name and last name #2417

Closed
wants to merge 1 commit into from

Conversation

Piyush132000
Copy link

@Piyush132000 Piyush132000 commented Jan 28, 2023

First Name , Last Name 'name' attribute value previously in camel-case order due to this it was not working properly and not suggesting us a first name, same bug also for last name so i have changed it to lower case and now it working as an expected.

First Name and Last name autocomplete feature not working properly due to the wrong value assigned to the name attribute.

Motivation

It will fix the autocomplete example and suggest a first name and last name.

Additional details

Related issues and pull requests

Fix #2416

First Name , Last Name 'name' attribute value previously in camel-case order due to this it was not working properly and not suggesting us a first name, same bug also  for last name so i have changed it to lower case and now it working as an expected.
@github-actions
Copy link

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Feb 27, 2023
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Jun 14, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jul 14, 2023
@estelle
Copy link
Member

estelle commented Jul 28, 2023

Thank you for your contribution. The casing of the name attribute was not the issue. It's been updated to include id attributes, which it was missing. As this is not the solution, and there is a merge conflict, I'll close this.

@estelle estelle closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months. merge conflicts 🚧
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First Name name attribute wrong value assigned
2 participants