Update attribute-autocomplete.html #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated attribute-autocomplete.html to include id's corresponding to the respective labels' for attributes. Resolving issue #27126.
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
NiedziolkaMichal
approved these changes
Jun 13, 2023
|
@NiedziolkaMichal Hello 👋🏼 thank you for the review and approval. Anything else for me to do here or shall I just close down the pull request? |
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
|
Everything looks good, thank you for this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated attribute-autocomplete.html to include id's corresponding to the respective labels' for attributes. Resolving issue #27126.
Description
Added id's within
<input>that correspond to the<label>'s for attribute.Motivation
Previous source code did not allow the user to focus the inputs by clicking on the corresponding label, which is the whole point of the interactive demo.
Additional details
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
To explicitly associate a element with an element, you first need to add the id attribute to the element. Next, you add the for attribute to the element, where the value of for is the same as the id in the element.
Related issues and pull requests
Fixes issue #27126.