Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(formatting): Apply default printWidth for JS / CSS #2648

Merged
merged 2 commits into from
Nov 1, 2023
Merged

chore(formatting): Apply default printWidth for JS / CSS #2648

merged 2 commits into from
Nov 1, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Oct 31, 2023 •
edited
Loading

Description

  • Remove 120 char printWidth configuration in .prettierrc.json
    • excluding HTML & markdown files for now. Checking removal of these in a follow-up.
  • In parallel: use example.com for domains where possible instead of real domains

Motivation

JS and CSS examples should follow the same formatting as in mdn/content

Additional details

Types of changes and summary:

For the following files, here's my personal opinion of whether the changes are acceptable or not:

  • live-examples/css-examples/color/color-adjust.css -> not used in content
  • live-examples/css-examples/fonts/font-synthesis.css -> non-visible change
  • live-examples/css-examples/fonts/font-variant-east-asian.css -> non-visible change
  • live-examples/css-examples/fragmentation/break.js -> non-visible change
  • live-examples/css-examples/motion-path/offset-anchor.css -> non-visible change
  • live-examples/css-examples/rhythm/line-height-step.css -> non-visible change
  • live-examples/css-examples/shapes/shape-image-threshold.css -> non-visible change
  • live-examples/html-examples/content-sectioning/css/article.css -> non-visible change
  • live-examples/html-examples/forms/css/button.css -> non-visible change
  • live-examples/html-examples/global-attributes/js/attribute-is.js -> not used in content
  • live-examples/html-examples/input/css/button.css -> non-visible change
  • live-examples/js-examples/array/array-at.js -> modified to fit line wrap
  • live-examples/js-examples/array/array-filter.js -> modified to fit line wrap
  • live-examples/js-examples/array/array-reduce-right.js -> adds line breaks, neutral change
  • live-examples/js-examples/array/array-reduce.js -> adds line breaks, neutral change
  • live-examples/js-examples/bigint/bigint-asintn.js -> adds line breaks, notable improvement
  • live-examples/js-examples/bigint/bigint-tolocalestring.js -> adds line breaks, neutral change
  • live-examples/js-examples/classes/classes-extends.js -> adds line breaks, neutral change
  • live-examples/js-examples/date/date-tolocaledatestring.js -> adds line breaks, improvement
  • live-examples/js-examples/finalizationregistry/finalizationregistry.js -> modified to fit line wrap
  • live-examples/js-examples/intl/intl-collator.js -> adds line breaks, neutral change
  • live-examples/js-examples/intl/intl-datetimeformat-prototype-format.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-datetimeformat-prototype-formatrange.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-datetimeformat-prototype-formattoparts.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-datetimeformat.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-displaynames.js -> adds line breaks, neutral change
  • live-examples/js-examples/intl/intl-listformat-prototype-formattoparts.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-listformat.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-locale-prototype-tostring.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-numberformat.js -> adds line breaks, improvement
  • live-examples/js-examples/intl/intl-segmenter-prototype-segment.js -> adds line breaks, improvement
  • live-examples/js-examples/json/json-stringify.js -> adds line breaks, improvement
  • live-examples/js-examples/map/map-groupby.js -> adds line breaks, improvement
  • live-examples/js-examples/promise/promise-allsettled.js -> adds line breaks, improvement
  • live-examples/js-examples/reflect/reflect-apply.js -> adds line breaks, improvement
  • live-examples/js-examples/statement/statement-async-for-in.js -> not used in content
  • live-examples/js-examples/string/string-at.js -> modified to fit line wrap
  • live-examples/js-examples/string/string-charcodeat.js -> modified, still wraps but is acceptable
  • live-examples/js-examples/string/string-includes.js -> adds line breaks, neutral change
  • live-examples/js-examples/string/string-indexof.js -> adds line breaks, neutral change
  • live-examples/js-examples/string/string-lastindexof.js -> adds line breaks, neutral change
  • live-examples/js-examples/string/string-replace.js -> adds line breaks, neutral change
  • live-examples/js-examples/string/string-replaceall.js -> adds line breaks, neutral change
  • live-examples/js-examples/string/string-search.js -> adds line breaks, neutral change
  • live-examples/js-examples/symbol/symbol-split.js -> adds line breaks, neutral change
  • live-examples/js-examples/typedarray/typedarray-at.js -> modified to fit line wrap
  • live-examples/js-examples/typedarray/typedarray-reduceright.js -> adds line breaks, improvement
  • live-examples/js-examples/typedarray/typedarray-tolocalestring.js -> adds line breaks, improvement
  • live-examples/js-examples/weakref/weakref.js -> modified to fit line wrap
  • live-examples/wat-examples/numeric/and.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/clz.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/ctz.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/or.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/popcnt.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/rotl.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/rotr.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/shl.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/shr.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/numeric/xor.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/wat-examples/statements/block.js -> adds indentation fix, wrapping / readability improvement
  • live-examples/webapi-examples/url/url-prototype-password.js -> not used in content, using example.com domain
  • live-examples/webapi-examples/url/url-prototype-search.js -> not used in content, using example.com domain
  • live-examples/webapi-examples/url/url-prototype-searchparams.js -> not used in content, using example.com domain
  • live-examples/webapi-examples/url/url-prototype-username.js -> not used in content, using example.com domain

Related issues and pull requests

@bsmth bsmth requested review from a team as code owners October 31, 2023 10:27
@bsmth bsmth requested review from estelle, Josh-Cena, hamishwillee and dipikabh and removed request for a team October 31, 2023 10:27
@bsmth bsmth mentioned this pull request Oct 31, 2023
Open
hamirmahal
hamirmahal reviewed Oct 31, 2023
View reviewed changes
live-examples/js-examples/array/array-reduce.js
Comment on lines +5 to +8
const sumWithInitial = array1.reduce(
(accumulator, currentValue) => accumulator + currentValue,
initialValue,
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix #2632.

bsmth
bsmth commented Nov 1, 2023
View reviewed changes
live-examples/js-examples/array/array-filter.js
@@ -1,4 +1,4 @@
const words = ['spray', 'limit', 'elite', 'exuberant', 'destruction', 'present'];
const words = ['spray', 'elite', 'exuberant', 'destruction', 'present'];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I manually removed this to fit to 80 chars max line length

@Rumyra Rumyra merged commit 16ecc54 into mdn:main Nov 1, 2023
5 checks passed
This was referenced Nov 1, 2023
Closed
Closed
@bsmth bsmth deleted the formatting-printWidth branch November 1, 2023 13:53
This was referenced Nov 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamirmahal hamirmahal hamirmahal left review comments

@Rumyra Rumyra Rumyra approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner automatically assigned from mdn/yari-content-javascript

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bsmth @Rumyra @hamirmahal