Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: place vendor-prefixed props first in declaration order #2812

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jul 17, 2024

Motivation

We should be placing vendor-prefixed props first in declaration order, followed by the standard props.

Changes:

  • re-order declarations when vendor-prefixed prop is required

Removals:

  • @-webkit-keyframes when @keyframes exists
  • -webkit-background-clip: text when background-clip: text is supported

Related issues and pull requests

Fixes #2797

@bsmth bsmth requested a review from a team as a code owner July 17, 2024 07:56
@bsmth bsmth requested review from estelle and removed request for a team July 17, 2024 07:56
@bsmth bsmth added the needs content update Needs update to the content to support this change. label Jul 17, 2024
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion.

LGTM.

Thanks! 🎉

live-examples/css-examples/pseudo-class/autofill.css Outdated Show resolved Hide resolved
@bsmth
Copy link
Member Author

bsmth commented Jul 18, 2024

TY merging now

@bsmth bsmth merged commit 182fa05 into mdn:main Jul 18, 2024
5 checks passed

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs content update Needs update to the content to support this change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad practise in examples (prefixed property last)
2 participants