This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Bug 759212: allow more HTML attributes in content. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow attributes commonly used on tables in dekiwiki, such as the one on https://developer.mozilla.org/en/DOM/DOM_event_reference
| @@ -57,12 +57,12 @@ | |||
| ALLOWED_ATTRIBUTES['a'] = ['style', 'id', 'class', 'href', 'title', ] | |||
| ALLOWED_ATTRIBUTES.update(dict((x, ['style', 'name', ]) for x in | |||
| ('h1', 'h2', 'h3', 'h4', 'h5', 'h6'))) | |||
| ALLOWED_ATTRIBUTES.update(dict((x, ['id', ]) for x in ( | |||
| ALLOWED_ATTRIBUTES.update(dict((x, ['id', 'style', 'class']) for x in ( | |||
There was a problem hiding this comment.
allowing style scares me - too open for security exploits? e.g., http://html5sec.org/#9
how vital is it?
There was a problem hiding this comment.
@groovecoder it's already allowed for headings per the line just above the one I changed, so I'm not sure why it shouldn't be allowed everywhere. I don't know how vital is it, though, but I do know that deki allows it.
There was a problem hiding this comment.
sounds like it's widely used. and bleach has a tight regex on the attribute values that should prevent javascript exploits.
groovecoder
added a commit
that referenced
this pull request
Jun 1, 2012
Bug 759212: allow more HTML attributes in content.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow attributes commonly used on tables in dekiwiki, such as the one on
https://developer.mozilla.org/en/DOM/DOM_event_reference
https://bugzilla.mozilla.org/show_bug.cgi?id=759212