Bug 1145630: Social Sharing A/B tests #3142
Conversation
|
This is not ready yet. It lacks one significant thing... a way to make the share links visible. This is a tini bit complicated for the one in the .toc. Putting it here because I know @openjck was talking about working on optimizely tests at the hack event, thought he might want to steal it. I intend to come back to this after my doctor's appointment today and fix the one missing thing but it's a Friday and I might get captured by a wild beer. |
|
Cleaned up and ready for review. |
|
This. Looks. Awesome. 😃 Will we plan to keep all three styles around after the experiment ends? If not, maybe we could add some comments to code that might later be eligible to be removed. |
| } | ||
|
|
||
|
|
||
| @media all and (max-width: 1200px) { |
There was a problem hiding this comment.
We could alternatively use $media-query-small-desktop here.
|
Added a few nitpick line comments. All very minor. Otherwise this looks fantastic. I'm excited to run this experiment. |
Styling for 3 different types of buttons going in 3 different places. Classes: .share .share.share-group .share.share-thin All hidden by default at the moment and need the class .show added to them to display.
|
Updated and ready for re-review. |
|
When we run the experiment, would we want to show all buttons at once or experiment with different placements in addition to different styles? |
|
The buttons should only show up in one place on the page at a time. |
…tests Bug 1145630: Social Sharing A/B tests
Styling for 3 different types of buttons going in 3 different places.
Classes:
.share
.share.share-group
.share.share-thin
All hidden by default at the moment, show by adding class
showto the element with classshareHere's a screen shot of the
share.share-thinpositioned under the title,share.share-grouppositioned in the TOC, and the default.shareunder the article.