Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

"Google +" to "Google+" #3184

Merged
merged 1 commit into from
Apr 16, 2015
Merged

"Google +" to "Google+" #3184

merged 1 commit into from
Apr 16, 2015

Conversation

yfdyh000
Copy link
Contributor

I think this "Google +" is strange, usually "Google+" or "Google Plus".

Related pull requests: #3124, #3142.

jezdez added a commit that referenced this pull request Apr 16, 2015
@jezdez jezdez merged commit 08dcd12 into mdn:master Apr 16, 2015
@groovecoder
Copy link
Contributor

@yfdyh000 - thanks for the contribution. Next time, please remember to include a bug # in the commit message, per our CONTRIBUTING guidlines.

@yfdyh000
Copy link
Contributor Author

@groovecoder Yes, I know. It is a minimal modification, so I want to skip this step.

Discuss large changes on the dev-mdn mailing list or on a bugzilla bug before coding.

I think this should apply to this situation.

But anyway, thank you for reminding.

@groovecoder
Copy link
Contributor

@yfdyh000 for sure, this didn't need an email to dev-mdn or its own bug. But, we could have re-used bug 875602 in the commit message.

I.e., bug 875062 - "Google +" to "Google+"

@yfdyh000
Copy link
Contributor Author

@groovecoder I feel this would be strange if I did not mention this modification in the bug. I mentioned the relevant pull in the pull, and I think this is enough.

@groovecoder
Copy link
Contributor

@yfdyh000 - we're certainly a little strange in the way we use both bugzilla and GitHub, so I totally understand. 😄

The nice thing about mentioning the bug # in the commit message, is that we have a GitHub hook that will automatically make a comment on the bug when the commit lands in master. So, the bug will automatically get a mention of the modification.

@yfdyh000
Copy link
Contributor Author

@groovecoder Ok, thank you for telling me about this feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants