This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
bug 1116335 - utf8_distinct_ci collation for Travis CI MySQL #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
force-pushed
the
django-upgrade-1116335
branch
9 times, most recently
from
2e26244
to
ed7e207
Compare
| @@ -52,7 +52,7 @@ | |||
| 'ATOMIC_REQUESTS': True, | |||
| 'TEST': { | |||
| 'CHARSET': 'utf8', | |||
| 'COLLATION': 'utf8_general_ci', | |||
| 'COLLATION': 'utf8_distinct_ci', | |||
There was a problem hiding this comment.
Why is this needed? The test runner will run the migrations and therefore apply the collation to the tables needing it.
There was a problem hiding this comment.
The test runner fails to apply the collation migration to Travis CI MySQL with an OperationalError so I'm trying some other approaches.
There was a problem hiding this comment.
It didn't for me, is this in your VM? What's the traceback?
There was a problem hiding this comment.
In the Travis CI environment. I'm still poking at it trying things today
groovecoder
force-pushed
the
django-upgrade-1116335
branch
from
ed7e207
to
90b94b7
Compare
|
For all of these comments: I'm just trying things out to see what the best way to make Travis work is. |
groovecoder
force-pushed
the
django-upgrade-1116335
branch
9 times, most recently
from
8c0a384
to
bb133f8
Compare
groovecoder
force-pushed
the
django-upgrade-1116335
branch
from
bb133f8
to
342ab6d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just sending a PR to trigger a Travis build ...