This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
bug 1402497: /favicon.ico redirect, try #2 #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redirect pattern fails when hashed assets are enabled, such as building the production Docker images. Instead, wait until runtime to compute the favicon.ico path.
escattone
approved these changes
Oct 2, 2017
There was a problem hiding this comment.
Works for me locally now with DEBUG=False, thanks @jwhitlock!
Codecov Report
@@ Coverage Diff @@
## master #4449 +/- ##
==========================================
+ Coverage 94.73% 94.73% +<.01%
==========================================
Files 260 260
Lines 22790 22801 +11
Branches 1674 1674
==========================================
+ Hits 21589 21600 +11
Misses 977 977
Partials 224 224
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redirect pattern fails when hashed assets are enabled, such as building the production Docker images. Instead, wait until runtime to compute the favicon.ico path.