Fix InterfaceOverview to properly close <dl>s

[ExE-Boss]

Supersedes and closes #691

TODO:

• Write tests
• Address Refactor APIRef/groupData macros for event reference changes sprints#906 (comment)

---

review?(@a2sheppy, @chrisdavidmills, @Elchi3, @wbamberg)

Depends on: #1093

[ExE-Boss]

Travis CI is once again not running the build correctly. 🤦🏻‍♂️

[davidflanagan]

Thanks for this @ExE-Boss. I hate to say this, but could you submit a different version where you don't run Prettier on the macro? The formatting changes make it harder to figure out what the bug fix is.

Also, I don't see anything in this PR or the one it supersedes that explains what the bug is that is being fixed. I need a bit of context so I understand what is being fixed before I review the fix.

I have reviewed your test file and have left some comments on that. I've got some style nits there, and some suggestions for code that could usefully be moved into utils.js for use by other tests.

[ExE-Boss]

Looks like Travis broke, again.

[davidflanagan]

@ExE-Boss: I'd like another round of changes. In particular I don't know what the right thing to do about the groupdata changes. I think we'd need Chris or @a2sheppy to weigh in on that, so it might be simpler to just not change the group stuff at all in this PR.

I've got a few suggestions about the changes to utils.js, but I think they're going to be really useful for other tests. @escattone and @wbamberg: I've suggested that ExE-Boss add readJSONFixture() and macro.mockTemplate() to the test utilities. If you have a chance, please take a look at those new functions and how they're used here in the InterfaceOverview.test.js file.

[ExE-Boss]

review?(@a2sheppy, @davidflanagan)