-
Notifications
You must be signed in to change notification settings - Fork 144
Update InterfaceOverview and GroupData for new event organisation #1315
Comments
I’m removing the |
Thanks @ExE-Boss . But removing the GroupData dependency from InterfaceOverview is a 6-line change, and mdn/kumascript#1073 adds 6000 lines. I'd really much rather we do this in small pieces. |
That’s because mdn/kumascript#1073, depends on mdn/kumascript#1093, which adds the necessary utility functions to write the tests for In fact, most of those lines are actually from the test fixtures. 1 By “reinventing the wheel” I’m referring to mocking macro output and loading test fixtures. |
When I wrote this I had expected to be removing events from GroupData: now I understand it better I won't be doing that. See #1314 (comment) for a description of what I am intending to do to GroupData, and mdn/kumascript#1136 for the PR that does it. Since |
Actually, |
The work I am doing here is the minimum needed to stop As far as I can see, If I'm wrong I'd love to know just how the event refactoring would break it and which changes are needed to fix that (although given that this macro has |
This is merged and deployed, see #1314 (comment). |
This is a work item for #685, and was originally discussed in #906.
This item also depends on #1314 and #1313.
Currently, events are listed in the GroupData JSON macro. and are referenced from there by other macros for building sidebars and other content.
After the event ref work, events will live directly under APIs, and should instead be treated more like properties and methods of those APIs.
In this user story we will:
AC are that both those changes are committed to KumaScript, deployed, and verified.
The text was updated successfully, but these errors were encountered: