This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Bug 754921: improve messages with invalid syntax #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comma) in ArgumentsJSON it raised a SyntaxError with no position
information, which was displayed to the user as:
Syntax error at line , column : Unexpected token
Also before this change all invalid parameter syntax (such as
{{macro(1,)}} matched the ArgumentsJSON production, thus hitting the bug
(1) described above.
Also improved a helper in test-macros.js to help newbies (like
myself) understand the structure of the testcase fixtures.