This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Compat: remove parenthesis around No; add title attribute #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
approved these changes
Jul 7, 2017
macros/Compat.ejs
Outdated
| @@ -103,10 +103,12 @@ function getVersionString(versionInfo) { | |||
| style="color: rgb(255, 153, 0);">${localize(compatStrings, 'supportsShort_unknown')}</span>`; | |||
| break; | |||
| case true: | |||
| return `<span style="color: #888">(${localize(compatStrings, 'supportsShort_yes')})</span>`; | |||
| return `<span title="${localize(compatStrings, 'supportsShort_yes_title')}" | |||
| style="color: #888">(${localize(compatStrings, 'supportsShort_yes')})</span>`; | |||
There was a problem hiding this comment.
@stephaniehobson:
There was a problem hiding this comment.
Should this be "(Yes)" in English and "«Да»" in Russian? In other words, should we move the parentheses inside the translated string?
| break; | ||
| case false: | ||
| return `<span style="color: #f00">(${localize(compatStrings, 'supportsShort_no')})</span>`; | ||
| return `<span title="${localize(compatStrings, 'supportsLong_no')}" | ||
| style="color: #f00">${localize(compatStrings, 'supportsShort_no')}</span>`; |
There was a problem hiding this comment.
@stephaniehobson :
|
Hopefully these inline styles will go away when we switch to the new compat tables :) |
jwhitlock
added a commit
to jwhitlock/kuma
that referenced
this pull request
Jul 10, 2017
* mdn/kumascript#213 - CommunityBox, DiscussionList: Discourse * mdn/kumascript#222 - SpecName, Spec2: GamepadExtensions * mdn/kumascript#223 - Add folder for no macros test * mdn/kumascript#224 - AddonSidebar: Submit an add-on link * mdn/kumascript#225 - Compat: Alpha-sort browsers * mdn/kumascript#226 - make lint and linting changes * mdn/kumascript#228 - CompatNo: Add Dutch translation * mdn/kumascript#230 - Compat: Remove parens around No, title * mdn/kumascript#231 - Glossary: Add Ukranian support * mdn/kumascript#232 - AddonSidebar: De-emphasise legacy addons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"No" is currently rendered as "(No)". The parenthesis only make sense for "(Yes)" and we never had them for "No". Adding title tooltips to further clarify the meanings as well.