This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Fix issue #276, update base url for interactive examples ejs #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
suggested changes
Aug 4, 2017
There was a problem hiding this comment.
Turns out EmbedGHLiveSample.ejs is used by a lot of other stuff. I think Will used it because it was a tool already available to him, rather than creating a new macro. I only know this because I already suggested deleting it once >_<
I'm happy to see the samples move to their new homes!
Remove EmbedGHLiveSample.ejs from the PR and it's R+
stephaniehobson
approved these changes
Aug 8, 2017
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Aug 8, 2017
* mdn/kumascript#235 - TopicBox: Add de translation * mdn/kumascript#271 - GroupData: Update WebVR sidebar * mdn/kumascript#275 - Move mozilla/kumascript to mdn/kumascript * mdn/kumascript#277 - EmbedInteractiveExample: Update URL * mdn/kumascript#278 - GroupData: Add Nav.mediaDevices.getUserMedia * mdn/kumascript#280 - Spec2: Mark SIMD Obsolete
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Aug 8, 2017
* mdn/kumascript#235 - TopicBox: Add de translation * mdn/kumascript#271 - GroupData: Update WebVR sidebar * mdn/kumascript#275 - Move mozilla/kumascript to mdn/kumascript * mdn/kumascript#277 - EmbedInteractiveExample: Update URL * mdn/kumascript#278 - GroupData: Add Nav.mediaDevices.getUserMedia * mdn/kumascript#280 - Spec2: Mark SIMD Obsolete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
URLinEmbedInteractiveExample.ejsand removesEmbedGHLiveSample.ejs