Added German translation for TopicBox macro #235
Conversation
SebastianZ
changed the title
SebastianZ
force-pushed
the
topicbox-de-translation
branch
from
16c82dd
to
1434f40
Compare
There was a problem hiding this comment.
@SebastianZ thanks for translating these strings. Looking at the French translation, I think the URLs should change from en-US to de as well.
macros/TopicBox.ejs
Outdated
| @@ -66,6 +66,12 @@ ircLink = "<a href='irc://irc.mozilla.org/" + ircChannelName + "'>#" + ircChanne | |||
| // Generate localized strings | |||
|
|
|||
| switch(env.locale) { | |||
| case "de": // German | |||
| headingStr = "Hilf dem '" + $0 + "'-Dokumentationsprojekt…"; | |||
| statusStr = "Schau dir den aktuellen <a href='/en-US/docs/" + driver.docStatus + "'>Status</a> der '" + $0 +"'-Dokumentation an."; | |||
There was a problem hiding this comment.
Should the URL be ``/de/docs/"?
macros/TopicBox.ejs
Outdated
| case "de": // German | ||
| headingStr = "Hilf dem '" + $0 + "'-Dokumentationsprojekt…"; | ||
| statusStr = "Schau dir den aktuellen <a href='/en-US/docs/" + driver.docStatus + "'>Status</a> der '" + $0 +"'-Dokumentation an."; | ||
| topicDriverStr = "Bereichsverantwortlicher: <a href='/en-US/profiles/" + driver.mdnPseudo + "'>" + driver.name + "</a> (IRC-Nickname: " + driver.ircPseudo + ")"; |
There was a problem hiding this comment.
Should the URL be '/de/profiles/'?
SebastianZ
force-pushed
the
topicbox-de-translation
branch
from
8fc425b
to
43e3264
Compare
|
Sorry for the long delay on this one! I've changed the URLs of all localizations to the localized ones. Sebastian |
There was a problem hiding this comment.
Thanks @SebastianZ! Much better now, and I'm glad you figured out the rebase to make the PR commits sane.
* mdn/kumascript#235 - TopicBox: Add de translation * mdn/kumascript#271 - GroupData: Update WebVR sidebar * mdn/kumascript#275 - Move mozilla/kumascript to mdn/kumascript * mdn/kumascript#277 - EmbedInteractiveExample: Update URL * mdn/kumascript#278 - GroupData: Add Nav.mediaDevices.getUserMedia * mdn/kumascript#280 - Spec2: Mark SIMD Obsolete
* mdn/kumascript#235 - TopicBox: Add de translation * mdn/kumascript#271 - GroupData: Update WebVR sidebar * mdn/kumascript#275 - Move mozilla/kumascript to mdn/kumascript * mdn/kumascript#277 - EmbedInteractiveExample: Update URL * mdn/kumascript#278 - GroupData: Add Nav.mediaDevices.getUserMedia * mdn/kumascript#280 - Spec2: Mark SIMD Obsolete
Actually, I failed to do the rebase, because after rebasing I had plenty of unrelated commits, which came from the master branch. (I'd be happy if someone could explain me how that could happen.) So I exported my changes into patches, deleted the local branch, recreated it, applied the patches, committed and force-pushed them. Sebastian |
|
@SebastianZ if you get into this situation again, get in touch with me. I can figure out what happened if you still have the commands you ran and their output, but I have no guesses why a rebase would go so badly. OK, maybe one guess. https://stackoverflow.com/questions/15316601/in-what-cases-could-git-pull-be-harmful#15316602 |
No description provided.