Conversation
What do you want out of a review? |
|
Failed on |
@jwhitlock that was just a network glitch: |
Next ran passed. Moving on... |
Failed on |
thanks @jwhitlock, it was passing locally b/c I ran |
In the development environment, you'd make a request like this to render the content of https://developer-local.allizom.org/en-US/docs/Mozilla:
When running this against Docker, I get:
There is no logging output from the The other production difference is that we create a
I don't know if any effort has been made to instead get config variables from the environment. The code suggests port |
The localhost port mapping works in linux and in the latest docker for mac beta (I recommend signing up for it if you haven't already), but assuming you're using the current release of docker-toolbox then you'll need to connect to the virtualbox vm's ip on that port, which can be obtained with Locally for me,
I haven't made any in this PR, but we can and should follow up on that after this PR lands. |
+r, merge when ready. |
FWIW, I had a commit on the heroku branch that made kumascript listen to process.env.port. Our |
Update the kumascript submodule to include the Docker PRs: mdn/kumascript#56 mdn/kumascript#57
@jwhitlock r?