Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Add tests to avoid division by zero #665

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Add tests to avoid division by zero #665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c415572
Add tests to avoid division by zero
Porkepix Apr 5, 2018
ed58545
Fixing default and rearranging var scope
SphinxKnight Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions macros/L10nStatusOverview.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,28 @@ getPages(pageList);
<tbody>
<%
for (var key in result) {
if (result.hasOwnProperty(key) && typeof key != 'undefined') {
var pageCounter = result[key].metrics.pages.counter || 0;
var translationCounter = result[key].metrics.translations.counter || 0;
var updateCounter = result[key].metrics.updateNeeded.counter || 0;
if (result.hasOwnProperty(key) && typeof key != 'undefined') {
var pageCounter = result[key].metrics.pages.counter || 0;
var translationCounter = result[key].metrics.translations.counter || 0;
var updateCounter = result[key].metrics.updateNeeded.counter || 0;

totalPages += pageCounter;
totalTranslated += translationCounter;
totalUpToDate += updateCounter;

var translationPercent = Math.floor((translationCounter / pageCounter) * 100);
var uptodatePercent = Math.floor((updateCounter / pageCounter) * 100);
totalPages += pageCounter;
totalTranslated += translationCounter;
totalUpToDate += updateCounter;

var translationPercent = 0;
var uptodatePercent = 0;
if (pageCounter !== 0) {
translationPercent = Math.floor((translationCounter / pageCounter) * 100);
uptodatePercent = Math.floor((updateCounter / pageCounter) * 100);
}

var totalTranslatedPercent = Math.floor((totalTranslated / totalPages) * 100);
var totalUpToDatePercent = Math.floor((totalUpToDate / totalPages) * 100);
var totalTranslatedPercent = 0;
var totalUpToDatePercent = 0;
if (totalPages !== 0) {
totalTranslatedPercent = Math.floor((totalTranslated / totalPages) * 100);
totalUpToDatePercent = Math.floor((totalUpToDate / totalPages) * 100);
}
%>
<tr>
<td><a href="<%=result[key].url%>"><%=key.replace(statusStr, "", "i")%></a></td>
Expand Down