Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Refactor the stragglers #1318

Closed
wbamberg opened this issue Apr 12, 2019 · 6 comments
Closed

Refactor the stragglers #1318

wbamberg opened this issue Apr 12, 2019 · 6 comments
Assignees
Labels
Est:Medium Task estimated as medium (up to a day's work?)

Comments

@wbamberg
Copy link

This is a work item for #685.

I just went through what's left to move out of Web/Events and all remaining events are accounted for in stories except 5, I think because those 5 pages were created after the audit spreadsheet.

https://developer.mozilla.org/en-US/docs/Web/Events/beforeinput
https://developer.mozilla.org/en-US/docs/Web/Events/clipboardchange
https://developer.mozilla.org/en-US/docs/Web/Events/connect
https://developer.mozilla.org/en-US/docs/Web/Events/payerdetailchange
https://developer.mozilla.org/en-US/docs/Web/Events/toggle

AC:

  • these 5 pages are moved, refactored, reviewed
  • BCD is submitted, reviewed, merged
@chrisdavidmills chrisdavidmills added Content Est:Medium Task estimated as medium (up to a day's work?) labels Apr 17, 2019
@chrisdavidmills
Copy link
Contributor

BCD now submitted too: mdn/browser-compat-data#3994.

@Elchi3 will probably review the BCD; @wbamberg can you have a look at the pages today? Thanks chaps.

@wbamberg
Copy link
Author

Thank you for taking these @chrisdavidmills .

For all pages, please make sure the order of rows in the blue boxes is consistent, as per #685 (comment). We're a bit vague on whether it's OK to include additional rows, so I think: if the additional rows seem useful, keep them, but if not (e.g. "Default action: None") don't.

https://developer.mozilla.org/en-US/docs/Web/API/HTMLDetailsElement/toggle_event

Looks good. Nice live example from @mfluehr :)

https://developer.mozilla.org/en-US/docs/Web/API/PaymentResponse/payerdetailchange_event

The "Event handler property" link was wrong (should be https://developer.mozilla.org/en-US/docs/Web/API/PaymentResponse/onpayerdetailchange I think) but I just fixed it.

https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/connect_event

This bit:

Note: The data property of the event object used to be null in Firefox. As of version 65 it is now initialized to an empty string, as per spec (bug 1508824).

...would be better in BCD. Not a blocker though, but maybe worth a follow-up BCD PR?

https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/beforeinput_event

Looks good.

@chrisdavidmills
Copy link
Contributor

@wbamberg thanks for the review!

So, it looks like the only thing was the make the order of the table rows in the blue box consistent. I've done this now, making the order of the first 4 rows bubbles, cancellable, interface, then event handler property. As for other rows, I've deleted the ones that weren't useful, and moved any others below the first four.

Florian has already merged the BCD for this, so I'll update the connect BCD as suggested above in a separate PR.

@chrisdavidmills
Copy link
Contributor

Note added to BCD in mdn/browser-compat-data#4010

@wbamberg
Copy link
Author

Your updates look good, I've merged mdn/browser-compat-data#4010, so let's close this one. Nice work @chrisdavidmills !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Est:Medium Task estimated as medium (up to a day's work?)
Projects
None yet
Development

No branches or pull requests

2 participants