-
Notifications
You must be signed in to change notification settings - Fork 144
Refactor the stragglers #1318
Comments
BCD now submitted too: mdn/browser-compat-data#3994. @Elchi3 will probably review the BCD; @wbamberg can you have a look at the pages today? Thanks chaps. |
Thank you for taking these @chrisdavidmills . For all pages, please make sure the order of rows in the blue boxes is consistent, as per #685 (comment). We're a bit vague on whether it's OK to include additional rows, so I think: if the additional rows seem useful, keep them, but if not (e.g. "Default action: None") don't.
Looks good. Nice live example from @mfluehr :)
The "Event handler property" link was wrong (should be https://developer.mozilla.org/en-US/docs/Web/API/PaymentResponse/onpayerdetailchange I think) but I just fixed it.
This bit:
...would be better in BCD. Not a blocker though, but maybe worth a follow-up BCD PR?
Looks good. |
@wbamberg thanks for the review! So, it looks like the only thing was the make the order of the table rows in the blue box consistent. I've done this now, making the order of the first 4 rows bubbles, cancellable, interface, then event handler property. As for other rows, I've deleted the ones that weren't useful, and moved any others below the first four. Florian has already merged the BCD for this, so I'll update the connect BCD as suggested above in a separate PR. |
Note added to BCD in mdn/browser-compat-data#4010 |
Your updates look good, I've merged mdn/browser-compat-data#4010, so let's close this one. Nice work @chrisdavidmills ! |
This is a work item for #685.
I just went through what's left to move out of Web/Events and all remaining events are accounted for in stories except 5, I think because those 5 pages were created after the audit spreadsheet.
https://developer.mozilla.org/en-US/docs/Web/Events/beforeinput
https://developer.mozilla.org/en-US/docs/Web/Events/clipboardchange
https://developer.mozilla.org/en-US/docs/Web/Events/connect
https://developer.mozilla.org/en-US/docs/Web/Events/payerdetailchange
https://developer.mozilla.org/en-US/docs/Web/Events/toggle
AC:
The text was updated successfully, but these errors were encountered: