Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation for the ascent-override CSS descriptor reference. #1752

Merged
merged 5 commits into from
Jul 29, 2021

Conversation

audrasjb
Copy link
Contributor

This PR adds a French translation for the ascent-override CSS descriptor reference.

Please note that I asked a question about the best practice for cssxref references translation here: https://matrix.to/#/!pGdhkeiUTYDIWuskqX:mozilla.org/$bdvXKWkU1RyybuAjp0JmacC9RK8I2r7sF6yuhtIIFZM?via=mozilla.org&via=t2bot.io&via=matrix.org

@audrasjb audrasjb requested a review from a team as a code owner July 27, 2021 20:04
@audrasjb audrasjb requested review from tristantheb and removed request for a team July 27, 2021 20:04
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Jul 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2021

Preview URLs

Flaws

URL: /fr/docs/Web/CSS/@font-face/ascent-override
Title: ascent-override
on GitHub
Flaw count: 3

  • macros:
    • /fr/docs/Web/CSS/@font-face/descent-override does not exist but fallbacked on /en-US/docs/Web/CSS/@font-face/descent-override
    • /fr/docs/Web/CSS/@font-face/font-variant does not exist but fallbacked on /en-US/docs/Web/CSS/@font-face/font-variant
    • /fr/docs/Web/CSS/@font-face/line-gap-override does not exist but fallbacked on /en-US/docs/Web/CSS/@font-face/line-gap-override

External URLs

URL: /fr/docs/Web/CSS/@font-face/ascent-override
Title: ascent-override
on GitHub

(this comment was updated 2021-07-28 08:59:23.493341)

Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight changes and we're good to merge :)

---
<p>{{CSSRef}}</p>

<p>Le descripteur CSS <strong><code>ascent-override</code></strong> définit la mesure du jambage supérieur (ascendant) de la police. La mesure du jambage supérieur correspond à la distance verticale par rapport à la hauteur d'X (hauteur du caractère bas de casse, à l'exclusion des jambages inférieurs et supérieurs) que CSS doit utiliser pour agencer les boîtes dans un contexte de formatage en ligne.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a bit of a stretch here but I'd point to https://en.wikipedia.org/wiki/Ascender_(typography) to have a visual clue of an ascender (/me crying a bit as the wiki page for "Hauteur d'ascendante" in fr doesn't exist yet)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link the "Jambage" Wikipedia article instead?
https://fr.wikipedia.org/wiki/Jambage
(it includes both "jambage inférieur" and "jambage supérieur")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed a proposal: 2449a8a
waiting for your review (no hurry!) before applying it to the other occurences (like descent-override)

files/fr/web/css/@font-face/ascent-override/index.html Outdated Show resolved Hide resolved
Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) (I should maybe start contributing to Wikipédia :) )

@SphinxKnight SphinxKnight merged commit 2b7a12d into mdn:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants