Update context-menu-demo #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymckay
approved these changes
Aug 25, 2017
There was a problem hiding this comment.
Looks good. My only concern is that we don't have a comment that contextMenus still work and if you want cross browser support you can use both (menus for the Firefox bits and contextMenus for both). Not sure if that would make the example too complicated, or just something to drop in the readme or MDN docs.
r+
added 2 commits
September 8, 2017 14:23
* origin/master: change shortcut to Ctrl+Shift+U for commands example (#264) Update `proxy-blocker` extension to be compatible with firefox 56+ (#260) Update eslint and .travis.yml (#259) add in titlePreface (#256) Hellosct1 webext (#237) Remove 'highlight', as Firefox does not support it (#252) Reflect bookmark state in icon title to make it accessible to screen readers (#255)
|
Thanks @andymckay , I've added a note to the README about this. |
wbamberg
pushed a commit
that referenced
this pull request
Sep 12, 2017
…fixes * origin/master: (26 commits) convert chrome. to browser. Issue #165 #166 (#262) Update examples.json for contextMenus->menus change (#282) Update context-menu-demo (#272) change shortcut to Ctrl+Shift+U for commands example (#264) Update `proxy-blocker` extension to be compatible with firefox 56+ (#260) Update eslint and .travis.yml (#259) add in titlePreface (#256) Hellosct1 webext (#237) Remove 'highlight', as Firefox does not support it (#252) Reflect bookmark state in icon title to make it accessible to screen readers (#255) Adding listing/descriptions for the imagify and themes examples. (#253) Selfify example (#251) New theme examples (#248) Example: embedded webextension overlay (#249) Add an indexedDB file storage example: image-reference-collector (#224) webextension -> extension (#250) more fields into package.json Add travis-ci build status badge Add .travis.yml more .eslintrc.json and fixes ...
wbamberg
pushed a commit
that referenced
this pull request
Oct 10, 2017
* origin/master: (149 commits) Add some icons (#285) add in simple http-response example (#281) convert chrome. to browser. Issue #165 #166 (#262) Update examples.json for contextMenus->menus change (#282) Update context-menu-demo (#272) change shortcut to Ctrl+Shift+U for commands example (#264) Update `proxy-blocker` extension to be compatible with firefox 56+ (#260) Update eslint and .travis.yml (#259) add in titlePreface (#256) Hellosct1 webext (#237) Remove 'highlight', as Firefox does not support it (#252) Reflect bookmark state in icon title to make it accessible to screen readers (#255) Adding listing/descriptions for the imagify and themes examples. (#253) Selfify example (#251) New theme examples (#248) Example: embedded webextension overlay (#249) Add an indexedDB file storage example: image-reference-collector (#224) webextension -> extension (#250) more fields into package.json Add travis-ci build status badge ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the context-menu-demo example to reflect changes which landed in https://bugzilla.mozilla.org/show_bug.cgi?id=1268020 and https://bugzilla.mozilla.org/show_bug.cgi?id=1333403.