-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding example of protocol_handlers #451
Conversation
Hi @rebloor , can you review this? |
@tsl143 I expect to do this next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thank you, just a few language nits. Please also update examples.json with details of the example. Thank you.
open-irc-links/README.md
Outdated
|
||
## What it does | ||
|
||
This add-on sets default client for opening IRC links using protocol_handlers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add "the" before "default" i.e. "… sets the default client …"
open-irc-links/README.md
Outdated
|
||
This add-on sets default client for opening IRC links using protocol_handlers. | ||
|
||
Whenever any link with IRC protocol is clicked it opens with pre-defined URI template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "Whenever a link using the IRC protocol is clicked, the link is opened in the URI defined in the add-on's manifest. In this example, all IRC protocol links are opened in mibbit.com."
open-irc-links/README.md
Outdated
This add-on sets default client for opening IRC links using protocol_handlers. | ||
|
||
Whenever any link with IRC protocol is clicked it opens with pre-defined URI template. | ||
For example click [here](irc://irc.freenode.net/drupal). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "For example, click this link to irc://irc.freenode.net/drupal and the protocol handler opens the Drupal channel in mibbit.com."
open-irc-links/README.md
Outdated
|
||
## What it shows | ||
|
||
* usage of protocol_handlers in webextension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "How to use protocol handlers to pass content to an application or website designed to handle that content."
open-irc-links/manifest.json
Outdated
{ | ||
"manifest_version": 2, | ||
"name": "IRC Protocol Handler", | ||
"description": "Demo the usage of protocol_handlers", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "Demos the use of protocol_handlers"
examples.json
Outdated
@@ -582,5 +582,10 @@ | |||
"windows.Window" | |||
], | |||
"name": "window-manipulator" | |||
}, | |||
{ | |||
"description": "Demonstrates usage of the protocol handlers.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to "Demonstrates the use of protocol handlers."
open-irc-links/README.md
Outdated
|
||
## What it does | ||
|
||
This add-on sets the default client for opening IRC links using protocol_handlers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, please format protocol_handlers
as code.
open-irc-links/README.md
Outdated
|
||
Whenever a link using the IRC protocol is clicked, the link is opened in the URI defined in the add-on's manifest. | ||
In this example, all IRC protocol links are opened in mibbit.com. | ||
For example, click [here](irc://irc.freenode.net/drupal) and the protocol handler opens the Drupal channel in mibbit.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expose the URL so the reader can see what they clicking. Also, we should probably point out they need to install the extension first:
"For example, once you've installed the extension, open this link irc://irc.freenode.net/drupal and the protocol handler opens the Drupal channel in mibbit.com."
adding example of protocol_handlers (mdn#451)
No description provided.