Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse var to let change #541

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Reverse var to let change #541

merged 3 commits into from
Oct 2, 2023

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Oct 1, 2023

Description

Fixes #536 (reverses the change made in #484)

@rebloor rebloor added bug Indicates an unexpected problem or unintended behavior. example New or updated example labels Oct 1, 2023
@rebloor rebloor requested a review from rpl October 1, 2023 22:09
@rebloor rebloor self-assigned this Oct 1, 2023
Rob--W
Rob--W approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the comment before merging.

root-cert-stats/background.js Show resolved Hide resolved
@rebloor @Rob--W
Review feedback
cf28d62 
Co-authored-by: Rob Wu <rob@robwu.nl>
@rebloor rebloor merged commit 709bc28 into mdn:main Oct 2, 2023
2 checks passed
@rebloor rebloor deleted the reverse-var-to-let-change branch October 2, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

@rpl rpl Awaiting requested review from rpl

Assignees

@rebloor rebloor

Labels
bug Indicates an unexpected problem or unintended behavior. example New or updated example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken root-cert-stats due to var -> let change
2 participants
@rebloor @Rob--W