Replace var with let in examples #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
store-collected-images/webextension-plain/deps/uuidv4.js
rpl
requested changes
Jul 8, 2022
| @@ -41,7 +41,7 @@ module.exports = { | |||
| }, | |||
| plugins: [ | |||
| // Since some NodeJS modules expect to be running in Node, it is helpful | |||
| // to set this environment var to avoid reference errors. | |||
| // to set this environment let to avoid reference errors. | |||
There was a problem hiding this comment.
this should be changed, the inline comment refers to OS environment variables.
| @@ -4,7 +4,7 @@ | |||
| } else if (typeof exports !== "undefined") { | |||
| factory(exports); | |||
| } else { | |||
| var mod = { | |||
| let mod = { | |||
There was a problem hiding this comment.
I think anything that is third party dependency for a webextensions-example (as in "coming from an outside repo") should be kept out of this change and left unmodified (and as a side note this part is not even part of that library, it is actually code injected automatically as part of the bundling).
|
@rpl thank you, I have reverted those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change replaces the use of the
varwithletin the examples. This addresses the requirement identified in "Replace var with let in code snippets and examples" #11343 (which in turn was originally identified in discussions on "Use const in place of var" #11135).After completing the global search and replace, a selection of examples was loaded and tested (approximately 10). Only store-collected-images was found to have issues, which were corrected by reverting the replace of
varwithletin store-collected-images/webextension-plain/deps/uuidv4.js