Reprioritize support

mdn · Apr 13, 2022 · 5f3ca4c · 5f3ca4c
1 parent e39f759
commit 5f3ca4c
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 25 deletions.
diff --git a/client/src/document/ingredients/browser-compatibility-table/feature-row.tsx b/client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
@@ -3,7 +3,7 @@ import type bcd from "@mdn/browser-compat-data/types";
 import { BrowserInfoContext } from "./browser-info";
 import {
   asList,
-  getFirst,
+  getCurrent,
   hasNoteworthyNotes,
   isFullySupportedWithoutLimitation,
   isNotSupportedAtAll,
@@ -46,7 +46,7 @@ function getSupportClassName(
   }
 
   let { flags, version_added, version_removed, partial_implementation } =
-    getFirst(support);
+    getCurrent(support);
 
   let className;
   if (version_added === null) {
@@ -55,13 +55,7 @@ function getSupportClassName(
     className = "preview";
   } else if (version_added) {
     className = "yes";
-    if (
-      (version_removed &&
-        !asList(support!).some((item) =>
-          isFullySupportedWithoutLimitation(item)
-        )) ||
-      (flags && flags.length)
-    ) {
+    if (version_removed || (flags && flags.length)) {
       className = "no";
     }
   } else {
@@ -80,7 +74,7 @@ function getSupportBrowserReleaseDate(
   if (!support) {
     return undefined;
   }
-  return getFirst(support).release_date;
+  return getCurrent(support).release_date;
 }
 
 function StatusIcons({ status }: { status: bcd.StatusBlock }) {
@@ -142,17 +136,12 @@ const CellText = React.memo(
     support: bcd.SupportStatement | undefined;
     browser: bcd.BrowserStatement;
   }) => {
-    const currentSupport =
-      (support &&
-        asList(support).find((item) =>
-          isFullySupportedWithoutLimitation(item)
-        )) ??
-      getFirst(support);
+    const currentSupport = getCurrent(support);
 
     const added = currentSupport?.version_added ?? null;
     const removed = currentSupport?.version_removed ?? null;
 
-    const browserReleaseDate = getSupportBrowserReleaseDate(currentSupport);
+    const browserReleaseDate = getSupportBrowserReleaseDate(support);
 
     let status:
       | { isSupported: "unknown" }
@@ -194,11 +183,7 @@ const CellText = React.memo(
         break;
     }
 
-    if (
-      removed &&
-      support &&
-      !asList(support).some((item) => isFullySupportedWithoutLimitation(item))
-    ) {
+    if (removed) {
       status = {
         isSupported: "no",
         label: (
@@ -287,7 +272,7 @@ function Icon({ name }: { name: string }) {
 }
 
 function CellIcons({ support }: { support: bcd.SupportStatement | undefined }) {
-  const supportItem = getFirst(support);
+  const supportItem = getCurrent(support);
   if (!supportItem) {
     return null;
   }

diff --git a/client/src/document/ingredients/browser-compatibility-table/utils.ts b/client/src/document/ingredients/browser-compatibility-table/utils.ts
@@ -73,13 +73,16 @@ export function hasNoteworthyNotes(support: bcd.SimpleSupportStatement) {
 }
 
 function hasLimitation(support: bcd.SimpleSupportStatement) {
+  return hasMajorLimitation(support) || support.notes;
+}
+
+function hasMajorLimitation(support: bcd.SimpleSupportStatement) {
   return (
     support.partial_implementation ||
     support.alternative_name ||
     support.flags ||
     support.prefix ||
-    support.version_removed ||
-    support.notes
+    support.version_removed
   );
 }
 
@@ -112,3 +115,45 @@ export function isFullySupportedWithoutLimitation(
 export function isNotSupportedAtAll(support: bcd.SimpleSupportStatement) {
   return !support.version_added && !hasLimitation(support);
 }
+
+function isFullySupportedWithMinorLimitation(
+  support: bcd.SimpleSupportStatement
+) {
+  return support.version_added && !hasMajorLimitation(support);
+}
+
+export function getCurrent<T>(a: T | T[]): T;
+// Prioritizes support items
+export function getCurrent(support: bcd.SupportStatement | undefined) {
+  if (!support) return getFirst(support);
+  // Full support without limitation
+  const noLimitationSupportItem = asList(support).find((item) =>
+    isFullySupportedWithoutLimitation(item)
+  );
+  if (noLimitationSupportItem) return noLimitationSupportItem;
+  // Full support with only notes and version_added
+  const minorLimitationSupportItem = asList(support).find((item) =>
+    isFullySupportedWithMinorLimitation(item)
+  );
+  if (minorLimitationSupportItem) return minorLimitationSupportItem;
+  // Full support with altname/prefix
+  const altnamePrefixSupportItem = asList(support).find(
+    (item) => !item.version_removed && (item.prefix || item.alternative_name)
+  );
+  if (altnamePrefixSupportItem) return altnamePrefixSupportItem;
+  // Partial support
+  const partialSupportItem = asList(support).find(
+    (item) => !item.version_removed && item.partial_implementation
+  );
+  if (partialSupportItem) return partialSupportItem;
+  // Support with flags only
+  const flagSupportItem = asList(support).find(
+    (item) => !item.version_removed && item.flags
+  );
+  if (flagSupportItem) return flagSupportItem;
+  // No/Inactive support
+  const noSupportItem = asList(support).find((item) => item.version_removed);
+  if (noSupportItem) return noSupportItem;
+  // Default (likely never reached)
+  return getFirst(support);
+}