Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP 404 page #3931

Closed
hamishwillee opened this issue May 30, 2021 · 11 comments
Closed

Update HTTP 404 page #3931

hamishwillee opened this issue May 30, 2021 · 11 comments
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up.

Comments

@hamishwillee
Copy link
Contributor

Please update the HTTP 404 page as show:

You've followed a link to a page that doesn't exist.

The page might not have been written yet or may have been deleted. It is also possible that the link URL is incorrect.
We recommend searching for similar topics on MDN.

To create this page, or just fix the link, please follow our instructions on content repo README.md

This follows discussion here: https://github.com/mdn/yari/discussions/3890

@peterbe
Copy link
Contributor

peterbe commented Jun 1, 2021

What should that link there be if the URL was something like /fr/docs/Web/Pagenotfound?

@peterbe
Copy link
Contributor

peterbe commented Jun 1, 2021

@wbamberg @Rumyra Can you sign off on Hamish's suggestion here?

@wbamberg
Copy link
Collaborator

wbamberg commented Jun 1, 2021

I'm happy with this, yes :). The only thing might be whether instead of directing them to https://github.com/mdn/content#contributing-to-the-content-of-mdn-web-docs (effectively asking them to fix it themselves) we direct them to https://github.com/mdn/content/issues (asking them to ask for it to be fixed). But I can see arguments on both sides, and this is a big improvement on what we have now.

@hamishwillee
Copy link
Contributor Author

Great!

I don't want to derail this being implemented, so as an aside, @wbamberg perhaps the first thing in https://github.com/mdn/content#contributing-to-the-content-of-mdn-web-docs could be a call to create issues, and recognise that as a contribution.

@peterbe
Copy link
Contributor

peterbe commented Jun 2, 2021

How about this then:

You've followed a link to a page that doesn't exist.

The page might not have been written yet or may have been deleted. It is also possible that the link URL is incorrect.
We recommend searching for similar topics on MDN.

To create this page, or just fix the link, please follow our instructions on content repo README.md

Or, if you prefer, file an issue about this first.

??

@wbamberg
Copy link
Collaborator

wbamberg commented Jun 2, 2021

I like having 2 separate links, an easy path to just file an issue as well as the link to the README. I think this is better than just sending people to the README, which is a forbidding document even if it links to the issue tracker early on.

I think "first" is odd in the second link as it implies that you have to fix the issue still after filing it. Is that what we want to imply?

If it were me I'd swap the order of "file an issue" and "fix it yourself":

You can file an issue about this on [MDN's issue tracker].

Or if you'd like to fix it yourself, please follow the contribution instructions on the [MDN content repo's README].

@hamishwillee
Copy link
Contributor Author

hamishwillee commented Jun 2, 2021

Sounds good. This is what I think we are all agreeing to (note that I don't like starting sentences with Or). Both of those points could be on the same line if we want.

You've followed a link to a page that doesn't exist.

The page might not have been written yet or may have been deleted. It is also possible that the link URL is incorrect.
We recommend searching for similar topics on MDN.

You can file an issue about this on MDN's issue tracker.

If you'd like to fix it yourself, please follow the contribution instructions on the MDN content repo's README.

@wbamberg
Copy link
Collaborator

wbamberg commented Jun 2, 2021

sold!

@Rumyra
Copy link
Contributor

Rumyra commented Jun 3, 2021

Soz just catching up on this...

I'm concluding yes this is good - after writing a whole paragraph on thoughts and that's the tldr 😄

peterbe added a commit to peterbe/yari that referenced this issue Jun 3, 2021
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Dec 8, 2021
@caugner
Copy link
Contributor

caugner commented Nov 15, 2022

@hamishwillee In #7070, it would have been useful to mention this issue. 😉

@caugner caugner closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2022
@hamishwillee
Copy link
Contributor Author

Yes it would - sorry, my memory of silent year old issues perhaps not what it should be :-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up.
Projects
Development

Successfully merging a pull request may close this issue.

6 participants