Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent return value for resolveFundamental #1496

Merged
merged 1 commit into from
Oct 20, 2020
Merged

consistent return value for resolveFundamental #1496

merged 1 commit into from
Oct 20, 2020

Conversation

fiji-flo
Copy link
Contributor

No description provided.

peterbe
peterbe approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it but it looks very right.

@peterbe
Copy link
Contributor

peterbe commented Oct 20, 2020

How come we didn't notice it in CI? Is it worth adding to a test somewhere?

@escattone escattone merged commit 659fdb7 into mdn:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbe peterbe peterbe approved these changes

@escattone escattone escattone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fiji-flo @peterbe @escattone