chore(language-menu): use proper <a> tags #9505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoMcA
changed the title
https://github.com/orgs/mdn/discussions/365 removes another use of client-side navigation
LeoMcA
force-pushed
the
language-menu-links
branch
from
2df370c
to
d32e154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/orgs/mdn/discussions/365
Problem
The buttons in the dropdown language switcher menu, being buttons, couldn't be middle clicked to open in another tab.
Solution
Make them
<a>tags, also remove another use of client side navHow did you test this change?
yarn && yarn dev