Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update .nvmrc #9518

Merged
merged 1 commit into from
Aug 22, 2023
Merged

chore: update .nvmrc #9518

merged 1 commit into from
Aug 22, 2023

Conversation

OnkarRuikar
Copy link
Contributor

Need to do it because NodeJs 18.14.0(LTS) doesn't work as per #9384. For details about choosing v18.17 see the discussion in the content PR's thread.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tnx:

cd yari
Found '/path/to/yari/.nvmrc' with version <v18.17>
Now using node v18.17.1 (npm v9.6.7)
yarn && yarn dev
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
...
11:45:03 AM server.1    |  Listening on port 5042
11:45:03 AM server.1    |  Your EDITOR is set to: code
11:45:03 AM web.1       |  Starting the development server...
...
11:45:09 AM web.1       |  webpack compiled successfully
11:45:09 AM web.1       |  No issues found.
11:45:23 AM ssr.1       |  webpack compiled successfully
11:45:58 AM server.1    |  buildDocumentFromURL(/en-us/docs/web): 270.959ms
11:46:00 AM server.1    |  buildDocumentFromURL(/en-us/docs/web/http): 132.671ms

@bsmth bsmth merged commit 02a19a6 into mdn:main Aug 22, 2023
8 checks passed
@OnkarRuikar OnkarRuikar deleted the OnkarRuikar-patch-1 branch August 22, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants