Add composite DVs #119
Merged
Add composite DVs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 63.86% 63.40% -0.47%
==========================================
Files 41 41
Lines 10931 11033 +102
==========================================
+ Hits 6981 6995 +14
- Misses 3950 4038 +88
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Nice stuff, most of my comments are to get a better understanding about what is going on.
Two comments:
- Shall we rename
convertSensitivitytoDictand the reverse one? it seems it's of more general use than for just sensitivities - I assume this is done by the new map functions at the end of
DVGeo.py, but how are the DVs mapped back to the user at the end?
anilyil
reviewed
Mar 13, 2022
pygeo/parameterization/DVGeo.py
Outdated
| @@ -1237,6 +1239,30 @@ class in geo_utils. Using pointSelect discards everything in volList. | |||
|
|
|||
| return self.DV_listSectionLocal[dvName].nVal | |||
|
|
|||
| def addGeoDVComposite(self, dvName, ptSetName=None, u=None, scale=None): | |||
There was a problem hiding this comment.
Please add some comments or dosctrings briefly explaining that this is more of a preprocessing routine thats run on a single proc.
marcomangano
approved these changes
Mar 13, 2022
anilyil
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds composite DVs, which are linear combinations of existing DVs.
Expected time until merged
Somewhat urgent, by end of the week please.
Type of change
Testing
Tests will come at a later time.
Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted