Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the topID key for the mphys's LETE constraint. #134

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Added the topID key for the mphys's LETE constraint. #134

merged 2 commits into from
Apr 18, 2022

Conversation

friedenhe
Copy link
Collaborator

Purpose

Added a topID option for the LE/TE constraint for Mphys. This option is needed for 2D airfoil optimization to determine which direction is spanwise and vertical.

Expected time until merged

ASAP

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@friedenhe friedenhe requested a review from a team as a code owner April 17, 2022 23:16
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #134 (c3ed6aa) into main (fdcfe8b) will decrease coverage by 10.92%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #134       +/-   ##
===========================================
- Coverage   62.60%   51.68%   -10.93%     
===========================================
  Files          43       43               
  Lines       11207    11207               
===========================================
- Hits         7016     5792     -1224     
- Misses       4191     5415     +1224     
Impacted Files Coverage Δ
pygeo/mphys/mphys_dvgeo.py 0.00% <0.00%> (ø)
pygeo/parameterization/DVGeoMulti.py 0.40% <0.00%> (-89.42%) ⬇️
pygeo/constraints/areaConstraint.py 50.50% <0.00%> (-25.42%) ⬇️
pygeo/constraints/DVCon.py 67.15% <0.00%> (-3.69%) ⬇️
pygeo/pyBlock.py 45.37% <0.00%> (-1.65%) ⬇️
pygeo/parameterization/DVGeo.py 63.82% <0.00%> (-0.50%) ⬇️
pygeo/topology.py 54.92% <0.00%> (-0.23%) ⬇️
pygeo/__init__.py 100.00% <0.00%> (+10.52%) ⬆️
pygeo/parameterization/__init__.py 100.00% <0.00%> (+14.28%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

joanibal
joanibal previously approved these changes Apr 18, 2022
@friedenhe
Copy link
Collaborator Author

@joanibal It is very strange that the regression tests failed. I did not see a failed test, but the log file says bash exited with code 2 at the end...

@marcomangano marcomangano merged commit 7484ec5 into mdolab:main Apr 18, 2022
@friedenhe friedenhe deleted the topid branch April 18, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants