Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to relative imports for code within the package #149

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Aug 2, 2022

Purpose

I switched to using relative imports for the code inside the package. Things like examples or tests are outside of the package and therefore do not use relative imports.

Expected time until merged

A few days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner August 2, 2022 22:17
@ewu63 ewu63 requested review from hajdik and anilyil August 2, 2022 22:17
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #149 (48858b1) into main (c1547bc) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   63.72%   63.72%           
=======================================
  Files          47       47           
  Lines       11676    11676           
=======================================
  Hits         7441     7441           
  Misses       4235     4235           
Impacted Files Coverage Δ
pygeo/mphys/mphys_dvgeo.py 0.00% <0.00%> (ø)
pygeo/parameterization/DVGeoCST.py 88.78% <100.00%> (ø)
pygeo/parameterization/designVars.py 77.65% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@hajdik hajdik merged commit 409528f into main Aug 3, 2022
@hajdik hajdik deleted the update-imports branch August 3, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants