ESP tutorial #152
Merged
ESP tutorial #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 63.75% 63.75%
=======================================
Files 47 47
Lines 11786 11786
=======================================
Hits 7514 7514
Misses 4272 4272
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yqliaohk
reviewed
Aug 30, 2022
doc/esp_airfoil.rst
Outdated
| For information on how to install ESP and its dependencies for use in pyGeo, see the :ref:`installation page<install>`. | ||
|
|
||
| The FFD approach is sometimes preferred because it is easy to set up and has a lot of freedom in how the design variables can change the geometry. | ||
| Unfortunately, the FFD control points are the primary representation of the geometry, and in some cases it is preferred to have both an input geometry and an output geometry in more traditional formats, like CAD models. |
There was a problem hiding this comment.
"are" or "are not"? Or maybe it's just not clear to what you're trying to say here.
doc/install.rst
Outdated
| ------------- | ||
| The simplest way to install ESP so that it works with pyGeo is to use the Docker image mentioned above, which will have pyGeo and ESP both installed. | ||
| The ESP GUI can then be installed on your local machine for Mac, Windows, and Linux following the instructions in their README to view ESP models. | ||
| Our currently supported version is 1.20, which can be installed from the `archive <https://acdl.mit.edu/ESP/archive/>`. |
There was a problem hiding this comment.
this link does not seem to show properly in the built doc?
yqliaohk
previously approved these changes
Aug 31, 2022
marcomangano
approved these changes
Sep 16, 2022
yqliaohk
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding a simple ESP tutorial demonstrating how to use an ESP model with pyGeo and change the design variables
Expected time until merged
1 week
Type of change
Testing
The new example script should run in a docker image and produce a new CSM file,
modified.csm.Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted